cmd/openshift-install: Log Terraform errors when not in debug mode #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
approved
Contributor
|
/lgtm |
Member
Author
We want to spit these out right away, instead of asking the caller to re-run with --log-level=debug. The -no-color additions work around [1]; without them stripping newlines doesn't work, because there are color escapes in the way. Inserting a bug to test: $ git diff -U1 diff --git a/pkg/tfvars/tfvars.go b/pkg/tfvars/tfvars.go index d5f5543..8f44646 100644 --- a/pkg/tfvars/tfvars.go +++ b/pkg/tfvars/tfvars.go @@ -19,3 +19,3 @@ type config struct { Name string `json:"tectonic_cluster_name,omitempty"` - BaseDomain string `json:"tectonic_base_domain,omitempty"` + BaseDomain string `json:"xtectonic_base_domain,omitempty"` Masters int `json:"tectonic_master_count,omitempty"` $ hack/build.sh $ openshift-install cluster INFO Fetching OS image... INFO Using Terraform to create cluster... ERROR Failed to read tfstate ("/tmp/openshift-install-122374392/terraform.tfstate"): open /tmp/openshift-install-122374392/terraform.tfstate: no such file or directory ERROR Error: Error asking for user input: missing required value for "tectonic_base_domain" FATAL Failed to generate Cluster: failed to generate asset Cluster: failed to run terraform: failed to execute Terraform: exit status 1 [1]: hashicorp/terraform#15264
wking
force-pushed
the
terraform-errors
branch
from
8dc2d7c to
aa01311
Compare
Member
Author
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to spit these out right away, instead of asking the caller to re-run with
--log-level=debug.The
-no-coloradditions work around hashicorp/terraform#15264; without them stripping newlines doesn't work, because there are color escapes in the way.Inserting a bug to test: