pkg/tfvars: Drop AWS.Profile #466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
size/S
Contributor
|
/lgtm |
We've been involved in the profile decision since e915ab1 (platforms/aws: Allow specifying of AWS profile, 2017-11-07, coreos/tectonic-installer#2320). Instead, callers should select their profile using environment variables [1,2] and/or a shared credentials file [3,4]. The 'aws' command line tool uses the same files and environment variables [5,6,7]. Given that both our aws-sdx-go and Terraform dependencies agree on how these values should be collected, it seems easiest for us to just get out of the way and let the caller set this up directly. [1]: https://www.terraform.io/docs/providers/aws/#environment-variables [2]: https://docs.aws.amazon.com/sdk-for-go/api/aws/session/#hdr-Environment_Variables [3]: https://www.terraform.io/docs/providers/aws/#shared-credentials-file [4]: https://docs.aws.amazon.com/sdk-for-go/api/aws/session/#hdr-Shared_Config_Fields [5]: https://docs.aws.amazon.com/cli/latest/userguide/cli-config-files.html [6]: https://docs.aws.amazon.com/cli/latest/userguide/cli-multiple-profiles.html [7]: https://docs.aws.amazon.com/cli/latest/userguide/cli-environment.html
wking
force-pushed
the
drop-aws-profile-opinions
branch
from
b6987dd to
850f729
Compare
Member
Author
|
@abhinavdahiya: I pushed b6987dd -> 850f729 to fix a gofmt issue. Can you |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been involved in the profile decision since e915ab1 (coreos/tectonic-installer#2320). Instead, callers should select their profile using environment variables (docs here and here) and/or a shared credentials file (docs here and here). The `aws' command line tool uses the same files and environment variables. Given that both our aws-sdx-go and Terraform dependencies agree on how these values should be collected, it seems easiest for us to just get out of the way and let the caller set this up directly.
Fixes #336.
CC @sallyom