Bug 1946506: Bootstrap no longer relies on mdns by mandre · Pull Request #4821 · openshift/installer

mandre · 2021-04-06T09:51:30Z

Bootstrap no longer rely on mdns for name resolution. We can remove the --mdns-publisher-image flag for the bootstrap and remove the security group rules for mdns.

These rules where only defined for OpenStack plaform. This PR removes the rules for both UPI and IPI.

Also remove obsolete comment about coredns running with mdns plugin in documentation.

Depends on openshift/machine-config-operator#2465, to remove dependency on the coredns's mdns plugin.

Bootstrapping no longer uses mdns for node resolution, we can remove the security group rules for mdns. These rules where only defined for OpenStack plaform. This commit removes the rules for both UPI and IPI.

Bootstrap no longer rely on mdns for name resolution. We can remove the `--mdns-publisher-image` flag for the bootstrap. Also remove obsolete comment about coredns running with mdns plugin in documentation.

openshift-ci-robot · 2021-04-06T09:51:33Z

@mandre: This pull request references Bugzilla bug 1946506, which is invalid:

expected the bug to target the "4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1946506: Bootstrap no longer relies on mdns

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-04-06T09:51:43Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign sdodson after the PR has been reviewed.
You can assign the PR to them by writing /assign @sdodson in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mandre · 2021-04-06T09:52:34Z

/bugzilla refresh

openshift-ci-robot · 2021-04-06T09:52:45Z

@mandre: This pull request references Bugzilla bug 1946506, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @mike-nguyen

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mandre · 2021-04-06T09:53:03Z

/cc @cybertron

mandre · 2021-04-06T10:18:56Z

/hold
This PR needs to update docs/design/baremetal/networking-infrastructure.md and docs/design/openstack/networking-infrastructure.md to remove references to mDNS, also possibly using the opportunity to consolidate both docs into an on-prem design doc.

mandre · 2021-04-06T12:26:22Z

/retest

openshift-ci-robot · 2021-04-06T14:51:53Z

@mandre: This pull request references Bugzilla bug 1946506, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @mike-nguyen

Details

In response to this:

Bug 1946506: Bootstrap no longer relies on mdns

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cybertron · 2021-04-15T15:50:28Z

Changes so far lgtm.

/cc @Gal-Zaidman @jcpowermac @patrickdillon
in case the other on-prem platforms need similar changes.

Gal-Zaidman · 2021-04-18T08:38:13Z

/test e2e-ovirt

Gal-Zaidman · 2021-04-18T08:39:18Z

/cc @eslutsky

Can you please take a look at this PR ?

mandre · 2021-05-05T13:04:36Z

/retest

cybertron · 2021-05-13T14:14:26Z

/retest

The mdns removal change has merged, so ci should be working now.

We're validating the cluster name size and there's no need to document this as a known issue, especially with mDNS going away. We might loosen the cluster name length restriction in the future.

There are still a lot of outdated info in this doc, however the DNS should be mostly correct now.

Remove all mentions of mDNS from the documentation as mDNS is no longer used. This change also clarifies this architecture is exactly the same as the BM one.

mandre · 2021-05-14T10:18:01Z

I've now updated the docs too.
/hold cancel

mandre · 2021-05-17T14:57:51Z

/retest

mandre · 2021-05-21T08:59:47Z

/retest

mandre · 2021-05-21T09:00:45Z

/test e2e-vsphere

mandre · 2021-05-21T18:47:59Z

/retest

mandre · 2021-05-27T08:53:34Z

/retest

mandre · 2021-05-27T15:55:23Z

The same test that failed this time worked in a previous run so I don't think the failures are related to the PR.
/test e2e-vsphere

cybertron

/lgtm

staebler · 2021-05-28T01:34:01Z

/approve

openshift-ci · 2021-05-28T01:34:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron, staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [staebler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-05-28T07:31:51Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-05-28T09:20:34Z

@mandre: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-vsphere	`be3ad9a`	link	`/test e2e-vsphere`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-05-28T09:31:50Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-05-28T10:01:48Z

@mandre: All pull requests linked via external trackers have merged:

Bugzilla bug 1946506 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1946506: Bootstrap no longer relies on mdns

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mandre added 2 commits April 6, 2021 11:40

Bug 1946506: Remove security group rules for mdns

c2680c5

Bootstrapping no longer uses mdns for node resolution, we can remove the security group rules for mdns. These rules where only defined for OpenStack plaform. This commit removes the rules for both UPI and IPI.

Bug 1946506: Remove mdns-publisher-image for bootstrap

99064c4

Bootstrap no longer rely on mdns for name resolution. We can remove the `--mdns-publisher-image` flag for the bootstrap. Also remove obsolete comment about coredns running with mdns plugin in documentation.

openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 6, 2021

openshift-ci-robot requested review from Fedosin and hardys April 6, 2021 09:51

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 6, 2021

openshift-ci-robot requested a review from mike-nguyen April 6, 2021 09:52

openshift-ci-robot requested a review from cybertron April 6, 2021 09:53

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 6, 2021

staebler mentioned this pull request Apr 6, 2021

Bug 1946506: Add hosts template for monitor-based resolution openshift/machine-config-operator#2465

Merged

openshift-ci-robot requested review from Gal-Zaidman, jcpowermac and patrickdillon April 15, 2021 15:50

openshift-ci-robot requested a review from eslutsky April 18, 2021 08:39

OpenStack: Remove known issue about mdns and long cluster names

23e5ef2

We're validating the cluster name size and there's no need to document this as a known issue, especially with mDNS going away. We might loosen the cluster name length restriction in the future.

mandre added 2 commits May 14, 2021 12:04

Update networking-infrastructure.md to reflect mDNS removal

ef00619

There are still a lot of outdated info in this doc, however the DNS should be mostly correct now.

OpenStack: Remove mention of mdns in networking-infrastructure.md

be3ad9a

Remove all mentions of mDNS from the documentation as mDNS is no longer used. This change also clarifies this architecture is exactly the same as the BM one.

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2021

cybertron approved these changes May 27, 2021

View reviewed changes

openshift-ci Bot assigned cybertron May 27, 2021

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2021

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2021

openshift-merge-robot merged commit 873a884 into openshift:master May 28, 2021

pierreprinetti deleted the mdns-removal branch June 19, 2023 08:57

Conversation

mandre commented Apr 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 6, 2021

Uh oh!

openshift-ci-robot commented Apr 6, 2021

Uh oh!

mandre commented Apr 6, 2021

Uh oh!

openshift-ci-robot commented Apr 6, 2021

Uh oh!

mandre commented Apr 6, 2021

Uh oh!

mandre commented Apr 6, 2021

Uh oh!

mandre commented Apr 6, 2021

Uh oh!

openshift-ci-robot commented Apr 6, 2021

Uh oh!

cybertron commented Apr 15, 2021

Uh oh!

Gal-Zaidman commented Apr 18, 2021

Uh oh!

Gal-Zaidman commented Apr 18, 2021

Uh oh!

mandre commented May 5, 2021

Uh oh!

cybertron commented May 13, 2021

Uh oh!

mandre commented May 14, 2021

Uh oh!

mandre commented May 17, 2021

Uh oh!

mandre commented May 21, 2021

Uh oh!

mandre commented May 21, 2021

Uh oh!

mandre commented May 21, 2021

Uh oh!

mandre commented May 27, 2021

Uh oh!

mandre commented May 27, 2021

Uh oh!

cybertron left a comment

Choose a reason for hiding this comment

Uh oh!

staebler commented May 28, 2021

Uh oh!

openshift-ci Bot commented May 28, 2021

Uh oh!

openshift-bot commented May 28, 2021

Uh oh!

openshift-ci Bot commented May 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented May 28, 2021

Uh oh!

openshift-ci Bot commented May 28, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

mandre commented Apr 6, 2021 •

edited

Loading

openshift-ci Bot commented May 28, 2021 •

edited

Loading