ibmcloud: Add Platform Provisioning Check#5063
ibmcloud: Add Platform Provisioning Check#5063openshift-merge-robot merged 5 commits intoopenshift:masterfrom
Conversation
Co-authored-by: Bobby Radford <bobbyradford@gmail.com>
d258bcd to
d335862
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jstuever The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@hasueki: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This adds platform provisioning check support for IBM Cloud. The check will validate if there's already a conflicting Kube API DNS record present in the user-provided CIS instance.
Changes:
ValidatePreExitingPublicDNS()GetDNSRecordsByName()GetZoneIDByName() --> GetDNSZoneIDByName()Move validation test suite toibmcloudpackageMove custom type definitions,DNSZoneResponse{}andEncryptionKeyResponse{}topkg/types/ibmcloud