Skip to content

vendor: update baremetal-operator#5176

Closed
hs0210 wants to merge 1 commit intoopenshift:masterfrom
hs0210:update-bmo-vendor
Closed

vendor: update baremetal-operator#5176
hs0210 wants to merge 1 commit intoopenshift:masterfrom
hs0210:update-bmo-vendor

Conversation

@hs0210
Copy link
Copy Markdown
Contributor

@hs0210 hs0210 commented Aug 30, 2021

update bmo vendor to make the API consistent with upstream

Signed-off-by: Hu Shuai hus.fnst@cn.fujitsu.com

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 30, 2021

Hi @hs0210. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 30, 2021
@openshift-ci openshift-ci Bot requested review from jhixson74 and rna-afk August 30, 2021 03:36
@hs0210
Copy link
Copy Markdown
Contributor Author

hs0210 commented Sep 8, 2021

Hi, Ping! Could anyone help take a look?
This PR updates bmo vendor which includes recent changes to RAID and BIOS API and these change will be used in the following PR where we process RAID and BIOS configuration.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 9, 2021
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 10, 2021
@hs0210
Copy link
Copy Markdown
Contributor Author

hs0210 commented Sep 16, 2021

Hi, PING. Thanks.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 26, 2021
@hs0210 hs0210 force-pushed the update-bmo-vendor branch 2 times, most recently from 2eb848d to aeede12 Compare September 27, 2021 02:02
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 27, 2021
@hs0210 hs0210 changed the title vendor: update baremetal-operator v0.0.0-20210826094604-f49936e9d431 vendor: update baremetal-operator Sep 27, 2021
@hs0210 hs0210 force-pushed the update-bmo-vendor branch from 8b5d8ac to b31bcdb Compare October 13, 2021 06:05
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 13, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jstuever after the PR has been reviewed.
You can assign the PR to them by writing /assign @jstuever in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hs0210
vendor: update baremetal-operator
b31bcdb 
update bmo vendor to make the API consistent with upstream

Signed-off-by: Hu Shuai <hus.fnst@cn.fujitsu.com>
@staebler
Copy link
Copy Markdown
Contributor

staebler commented Oct 22, 2021

@hs0210 Please include the commit from this PR in #5196, so that it is easier to track and justify the need for the version bump.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 22, 2021

@hs0210: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 22, 2021
@hs0210
Copy link
Copy Markdown
Contributor Author

hs0210 commented Oct 22, 2021

@staebler Thanks, Got it.

@hs0210
Copy link
Copy Markdown
Contributor Author

hs0210 commented Oct 29, 2021

@staebler done

@hs0210 hs0210 closed this Oct 29, 2021
@hs0210 hs0210 deleted the update-bmo-vendor branch January 28, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@rna-afk rna-afk Awaiting requested review from rna-afk

Assignees

No one assigned

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hs0210 @staebler