Skip to content

libvirt: bump memory of machines to 16G in the provider config #5230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Prashanth684 wants to merge 1 commit into from
Closed

libvirt: bump memory of machines to 16G in the provider config #5230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/asset/machines/libvirt/machines.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ func provider(clusterID string, networkInterfaceAddress string, platform *libvir
APIVersion: "libvirtproviderconfig.openshift.io/v1beta1",
Kind: "LibvirtMachineProviderConfig",
},
DomainMemory: 8192,
DomainMemory: 16384,
Copy link
Copy Markdown
Contributor

@praveenkumar praveenkumar Sep 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Prashanth684 we are using https://cloud.google.com/compute/docs/general-purpose-machines#n1_machines (n1-standard-16) and if we are increased the resource that much it means we are not able to accommodate cluster in this machine (I think standard e2e-libvirt runs 3master-3worker mode).

Copy link
Copy Markdown
Contributor Author

@Prashanth684 Prashanth684 Sep 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm..ok yeah n1-standard-15 has only 60G..so should we reduce worker nodes to 2 and keep it at 8192 and increase master memory to 12G then ?

Copy link
Copy Markdown
Contributor

@praveenkumar praveenkumar Sep 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Prashanth684 I will take a look tomorrow how it all link together and update you here, first we need to manual create a gcp instance (same resource) and try to start the cluster and see if it able to execute test as expected.

Copy link
Copy Markdown
Contributor

@cfergeau cfergeau Dec 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you get a chance to take a look at this?

Copy link
Copy Markdown
Contributor Author

@Prashanth684 Prashanth684 Dec 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i did kick off a libvirt e2e and as I am monitoring, i see that Praveen is right. the standard machines have 64G memory which is not sufficient for this change. But even otherwise, i think we need to look into bumping the gcp instance type to something beefier because the libvirt master defaults need to be 16G anyway for consistent CI runs

Copy link
Copy Markdown
Contributor

@barbacbd barbacbd May 3, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Prashanth684 the gcp request you mentioned should be accomplished in #5841

DomainVcpu: 4,
Ignition: &libvirtprovider.Ignition{
UserDataSecret: userDataSecret,
Expand Down