[MCO-8] machineconfig: Use KernelArguments field instead of kernel-args file#5439
Conversation
openshift-ci
Bot
requested review from
cgwalters,
craychee,
sinnykumari and
yuqi-zhang
|
I'll have to update the tests, too. |
LorbusChris
changed the title
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
@LorbusChris: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Thanks for the PR, can you also add steps on how to test this? |
LorbusChris
force-pushed
the
mc-kargs
branch
2 times, most recently
from
82df865 to
8185244
Compare
|
I've updated the unit tests, but I don't think the kargs that are actually in use are gathered anywhere in CI, so that might have to be checked manually. |
staebler
left a comment
staebler
left a comment
There was a problem hiding this comment.
/approve
I will leave it up to the CoreOS team to give it a lgtm once they are satisfied with the test results.
openshift-ci
Bot
added
the
approved
LorbusChris
changed the title
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
|
I think using the old interface was semi-intentional as far as ensuring it was tested. But...OTOH, yes everyone should be using the MCO path now. So... |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, staebler The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The MC KernelArguments field is the recommended way to set kernel args, and should be used in new installs as opposed to writing kernel args to the `/etc/pivot/kernel-args` file, which should be considered deprecated. In order to test this change, set `hyperthreading: Disabled` in the `install-config.yaml` and install a cluster. Once the installation has finished, `oc get mc` should show the following two MachineConfig objects among others: - 99-master-disable-hyperthreading - 99-worker-disable-hyperthreading To verify hyperthreading was actually disabled one the nodes, access a node via e.g. `oc debug node/<name>` and run `cat /sys/devices/system/cpu/smt/active`. It should show `0`.
|
@sinnykumari I have added instructions for testing this on the commit message |
openshift-ci
Bot
removed
the
do-not-merge/hold
|
@LorbusChris: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required |
|
Missed this PR earlier. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
6 participants
The MC KernelArguments field is the recommended way to set kernel args,
and should be used in new installs as opposed to writing kernel args to
the
/etc/pivot/kernel-argsfile, which should be considereddeprecated.
This should be considered a stop-gap solution until in-Ignition kargs support has landed in the MCO.
/cc @sinnykumari @yuqi-zhang @craychee @cgwalters
/hold
for testing