close a verify-codegen ci failure loophole by clnperez · Pull Request #5447 · openshift/installer

clnperez · 2021-12-02T19:43:37Z

if the go codegen commands failed, the the hack/verify-codegen.sh script continued and the CI check passed. see #5406 for an example. the script was not set to fail on a non-zero return code. this pr adds the bash e option to the set builtin to catch errors and exit on failure.

Signed-off-by: Christy Norman christy@linux.vnet.ibm.com

clnperez · 2021-12-02T20:12:12Z

The codegen tests fail now as they should:

Container test exited with code 1, reason Error
---
+ go generate ./pkg/types/installconfig.go
github.com/openshift/installer/pkg/types:-: conflicting types in allOf branches in schema: string vs DiskCategory
github.com/openshift/installer/pkg/types:-: conflicting types in allOf branches in schema: string vs DiskCategory
github.com/openshift/installer/pkg/types:-: conflicting types in allOf branches in schema: string vs DiskCategory
Error: not all generators ran successfully

We should merge #5406 first

clnperez · 2021-12-02T20:13:03Z

fyi @patrickdillon

jhixson74 · 2021-12-02T21:45:55Z

/lgtm

squidboylan · 2021-12-03T17:19:15Z

looks good to me

staebler · 2021-12-03T23:19:09Z

Just remove the set -x and set +x instead of going through the machinations of checking the return codes.

i added e instead

staebler · 2021-12-03T23:20:10Z

This is going to fail because the file no longer exists. We need a replacement for this. But we can comment it out for now.

clnperez · 2021-12-07T13:49:33Z

@staebler @jhixson74 PTAL at the updates

staebler

The changes look good.
Please improve upon the PR and commit title so that they are not quite so generic.

staebler · 2021-12-07T14:55:13Z

/approve

clnperez · 2021-12-07T17:32:31Z

i updated the summary comment and pr title. hopefully gh picks those up.

staebler · 2021-12-07T20:07:14Z

i updated the summary comment and pr title. hopefully gh picks those up.

You need to push up the commit with the updated message.

clnperez · 2021-12-08T18:43:33Z

@staebler done

staebler · 2021-12-08T18:47:42Z

Let's leave this up above the git diff as it was.

if the go codegen commands failed, the the hack/verify-codegen.sh script continued and the CI check passed. see openshift#5406 for an example. the script was not set to fail on a non-zero return code. this pr adds the bash e option to the set builtin to catch errors and exit on failure. Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com>

staebler

/lgtm
/approve

openshift-ci · 2021-12-09T13:25:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [staebler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

staebler · 2021-12-09T13:25:11Z

+  # See https://github.com/openshift/installer/pull/5447#discussion_r762340594
+  # go generate ./pkg/rhcos/ami.go


Fixed with #5466.

sounds like i should just delete those two commented-out lines now then @staebler?

No, leave them commented out. This PR will likely merge before mine.

openshift-bot · 2021-12-09T13:26:30Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-09T13:50:29Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-09T14:02:28Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-09T14:14:30Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-09T14:26:29Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-09T14:50:32Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-09T15:02:31Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-12-09T15:03:33Z

@clnperez: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-libvirt	`421e1e2`	link	false	`/test e2e-libvirt`
ci/prow/e2e-crc	`421e1e2`	link	false	`/test e2e-crc`
ci/prow/e2e-aws-fips	`421e1e2`	link	false	`/test e2e-aws-fips`
ci/prow/okd-e2e-aws	`421e1e2`	link	false	`/test okd-e2e-aws`
ci/prow/e2e-openstack	`421e1e2`	link	false	`/test e2e-openstack`
ci/prow/e2e-ovirt	`421e1e2`	link	false	`/test e2e-ovirt`
ci/prow/e2e-metal-ipi-ovn-ipv6	`421e1e2`	link	false	`/test e2e-metal-ipi-ovn-ipv6`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-12-09T15:14:32Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-09T15:26:31Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-09T15:38:32Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-09T16:15:03Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-09T16:28:04Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-09T16:40:59Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-09T16:54:00Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-09T17:06:59Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-09T17:19:59Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-09T17:32:06Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-09T17:44:28Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-09T17:57:23Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-09T18:09:35Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-09T18:21:29Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-09T18:33:22Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-09T18:45:19Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci Bot requested review from jhixson74 and squidboylan December 2, 2021 19:46

clnperez force-pushed the ci-codegen branch from fb01721 to ca54a3d Compare December 2, 2021 20:06

openshift-ci Bot assigned jhixson74 Dec 2, 2021

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2021

staebler reviewed Dec 3, 2021

View reviewed changes

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2021

clnperez force-pushed the ci-codegen branch 2 times, most recently from 1786131 to 6f6b93a Compare December 6, 2021 22:14

staebler reviewed Dec 7, 2021

View reviewed changes

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2021

clnperez changed the title ~~close a codegen loophole~~ close a verify-codegen ci failure loophole Dec 7, 2021

clnperez force-pushed the ci-codegen branch from 6f6b93a to 1ddcaec Compare December 8, 2021 18:41

staebler reviewed Dec 8, 2021

View reviewed changes

clnperez force-pushed the ci-codegen branch from 1ddcaec to 421e1e2 Compare December 8, 2021 23:37

staebler approved these changes Dec 9, 2021

View reviewed changes

openshift-ci Bot assigned staebler Dec 9, 2021

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2021

staebler reviewed Dec 9, 2021

View reviewed changes

openshift-merge-robot merged commit eaaf64f into openshift:master Dec 9, 2021

		# See https://github.com/openshift/installer/pull/5447#discussion_r762340594
		# go generate ./pkg/rhcos/ami.go

Conversation

clnperez commented Dec 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clnperez commented Dec 2, 2021

Uh oh!

clnperez commented Dec 2, 2021

Uh oh!

jhixson74 commented Dec 2, 2021

Uh oh!

squidboylan commented Dec 3, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

clnperez commented Dec 7, 2021

Uh oh!

staebler left a comment

Choose a reason for hiding this comment

Uh oh!

staebler commented Dec 7, 2021

Uh oh!

clnperez commented Dec 7, 2021

Uh oh!

staebler commented Dec 7, 2021

Uh oh!

clnperez commented Dec 8, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

staebler left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Dec 9, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

openshift-bot commented Dec 9, 2021

Uh oh!

openshift-bot commented Dec 9, 2021

Uh oh!

openshift-bot commented Dec 9, 2021

Uh oh!

openshift-bot commented Dec 9, 2021

Uh oh!

openshift-bot commented Dec 9, 2021

Uh oh!

openshift-bot commented Dec 9, 2021

Uh oh!

openshift-bot commented Dec 9, 2021

Uh oh!

openshift-ci Bot commented Dec 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Dec 9, 2021

Uh oh!

openshift-bot commented Dec 9, 2021

Uh oh!

openshift-bot commented Dec 9, 2021

Uh oh!

openshift-bot commented Dec 9, 2021

Uh oh!

openshift-bot commented Dec 9, 2021

Uh oh!

openshift-bot commented Dec 9, 2021

Uh oh!

openshift-bot commented Dec 9, 2021

Uh oh!

openshift-bot commented Dec 9, 2021

Uh oh!

openshift-bot commented Dec 9, 2021

clnperez commented Dec 2, 2021 •

edited

Loading

openshift-ci Bot commented Dec 9, 2021 •

edited

Loading