Add Nutanix-specific customizations to manifests by thunderboltsid · Pull Request #5631 · openshift/installer

thunderboltsid · 2022-02-10T14:42:56Z

Update templates in data/data/manifests
Add nutanix platform customizations in pkg/asset/manifests

thunderboltsid · 2022-03-16T17:59:22Z

/retest-required

thunderboltsid · 2022-03-16T18:07:30Z

/test all

rvanderp3 · 2022-03-16T18:23:31Z

/test all

thunderboltsid · 2022-03-17T07:38:30Z

/retest-required

rvanderp3 · 2022-03-17T13:40:03Z

/lgtm

rvanderp3 · 2022-03-17T16:03:03Z

/assign @patrickdillon

rvanderp3 · 2022-03-17T18:52:11Z

/assign @staebler

rvanderp3 · 2022-03-17T19:03:13Z

/unassign @patrickdillon

staebler · 2022-03-17T20:07:19Z

I am a bit surprised that there is not a cloud provider config. Is the name of the secret with the creds hard-coded somewhere?

Currently, yes. nutanix-credentials is the credential name.

- Update templates in data/data/manifests - Add nutanix platform customizations in pkg/asset/manifests

thunderboltsid · 2022-03-19T23:32:19Z

/retest-required

rvanderp3 · 2022-03-22T19:39:42Z

/lgtm

openshift-bot · 2022-03-28T06:50:35Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

thunderboltsid · 2022-03-28T09:02:01Z

/retest-required

openshift-bot · 2022-03-28T09:15:35Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-28T12:42:56Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-28T13:21:37Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

thunderboltsid · 2022-03-28T17:14:05Z

/retest-required

openshift-bot · 2022-03-28T18:25:36Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-28T19:25:37Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-28T21:38:37Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-28T21:50:39Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

thunderboltsid · 2022-03-28T22:18:04Z

/retest-required

thunderboltsid · 2022-03-29T00:05:20Z

/retest-required

openshift-bot · 2022-03-29T01:38:43Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-29T07:08:09Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-29T09:58:09Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-29T11:22:36Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

thunderboltsid · 2022-03-29T14:23:43Z

/retest-required

thunderboltsid · 2022-03-29T19:58:05Z

/retest-required

openshift-bot · 2022-03-29T20:00:30Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2022-03-29T23:02:12Z

@thunderboltsid: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-upi-xpn	`b146798`	link	false	`/test e2e-gcp-upi-xpn`
ci/prow/e2e-ibmcloud	`b146798`	link	false	`/test e2e-ibmcloud`
ci/prow/e2e-aws-shared-vpc	`b146798`	link	false	`/test e2e-aws-shared-vpc`
ci/prow/e2e-aws-disruptive	`b146798`	link	false	`/test e2e-aws-disruptive`
ci/prow/e2e-aws-fips	`b146798`	link	false	`/test e2e-aws-fips`
ci/prow/e2e-azurestack	`b146798`	link	false	`/test e2e-azurestack`
ci/prow/e2e-azure-upi	`b146798`	link	false	`/test e2e-azure-upi`
ci/prow/e2e-azure	`b146798`	link	false	`/test e2e-azure`
ci/prow/e2e-azure-shared-vpc	`b146798`	link	false	`/test e2e-azure-shared-vpc`
ci/prow/e2e-alibaba	`b146798`	link	false	`/test e2e-alibaba`
ci/prow/okd-e2e-aws-upgrade	`b146798`	link	false	`/test okd-e2e-aws-upgrade`
ci/prow/e2e-aws-proxy	`b146798`	link	false	`/test e2e-aws-proxy`
ci/prow/e2e-crc	`b146798`	link	false	`/test e2e-crc`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2022-03-30T00:32:54Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-30T02:03:54Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-30T03:47:58Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-30T04:26:55Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-30T05:38:56Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-30T09:15:00Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-30T10:50:58Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-30T11:14:55Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci Bot requested review from jstuever and rna-afk February 10, 2022 14:52

rvanderp3 reviewed Feb 21, 2022

View reviewed changes

Comment thread data/data/manifests/openshift/cloud-creds-secret.yaml.template

openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 16, 2022

thunderboltsid force-pushed the ntnx-3.1 branch from ac22a4d to 4da69f3 Compare March 16, 2022 13:20

openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 16, 2022

thunderboltsid force-pushed the ntnx-3.1 branch 2 times, most recently from 8af2bf7 to 03bc38d Compare March 16, 2022 13:58

thunderboltsid force-pushed the ntnx-3.1 branch from 03bc38d to 8b5a0f6 Compare March 16, 2022 19:36

openshift-ci Bot assigned rvanderp3 Mar 17, 2022

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2022

openshift-ci Bot assigned patrickdillon Mar 17, 2022

openshift-ci Bot assigned staebler Mar 17, 2022

openshift-ci Bot unassigned patrickdillon Mar 17, 2022

staebler reviewed Mar 17, 2022

View reviewed changes

thunderboltsid force-pushed the ntnx-3.1 branch from 8b5a0f6 to 8816265 Compare March 18, 2022 17:36

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2022

rvanderp3 reviewed Mar 18, 2022

View reviewed changes

Comment thread data/data/manifests/openshift/cloud-creds-secret.yaml.template Outdated

Add Nutanix-specific customizations to manifests

b146798

- Update templates in data/data/manifests - Add nutanix platform customizations in pkg/asset/manifests

thunderboltsid force-pushed the ntnx-3.1 branch from 8816265 to b146798 Compare March 19, 2022 15:44

openshift-merge-robot merged commit 6bc11a5 into openshift:master Mar 30, 2022

thunderboltsid deleted the ntnx-3.1 branch May 25, 2022 07:15

Conversation

thunderboltsid commented Feb 10, 2022

Uh oh!

Uh oh!

thunderboltsid commented Mar 16, 2022

Uh oh!

thunderboltsid commented Mar 16, 2022

Uh oh!

rvanderp3 commented Mar 16, 2022

Uh oh!

thunderboltsid commented Mar 17, 2022

Uh oh!

rvanderp3 commented Mar 17, 2022

Uh oh!

rvanderp3 commented Mar 17, 2022

Uh oh!

rvanderp3 commented Mar 17, 2022

Uh oh!

rvanderp3 commented Mar 17, 2022

Uh oh!

staebler Mar 17, 2022

Choose a reason for hiding this comment

Uh oh!

thunderboltsid Mar 18, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

thunderboltsid commented Mar 19, 2022

Uh oh!

rvanderp3 commented Mar 22, 2022

Uh oh!

openshift-bot commented Mar 28, 2022

Uh oh!

thunderboltsid commented Mar 28, 2022

Uh oh!

openshift-bot commented Mar 28, 2022

Uh oh!

openshift-bot commented Mar 28, 2022

Uh oh!

openshift-bot commented Mar 28, 2022

Uh oh!

thunderboltsid commented Mar 28, 2022

Uh oh!

openshift-bot commented Mar 28, 2022

Uh oh!

openshift-bot commented Mar 28, 2022

Uh oh!

openshift-bot commented Mar 28, 2022

Uh oh!

openshift-bot commented Mar 28, 2022

Uh oh!

thunderboltsid commented Mar 28, 2022

Uh oh!

thunderboltsid commented Mar 29, 2022

Uh oh!

openshift-bot commented Mar 29, 2022

Uh oh!

openshift-bot commented Mar 29, 2022

Uh oh!

openshift-bot commented Mar 29, 2022

Uh oh!

openshift-bot commented Mar 29, 2022

Uh oh!

thunderboltsid commented Mar 29, 2022

Uh oh!

thunderboltsid commented Mar 29, 2022

Uh oh!

openshift-bot commented Mar 29, 2022

Uh oh!

openshift-ci Bot commented Mar 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Mar 30, 2022

Uh oh!

openshift-bot commented Mar 30, 2022

Uh oh!

openshift-bot commented Mar 30, 2022

Uh oh!

openshift-bot commented Mar 30, 2022

openshift-ci Bot commented Mar 29, 2022 •

edited

Loading