bootkube: Use --image-references for MCO bootstrap#5703
bootkube: Use --image-references for MCO bootstrap#5703cgwalters wants to merge 1 commit intoopenshift:masterfrom
--image-references for MCO bootstrap#5703Conversation
Depends: openshift/machine-config-operator#3017 I want to add a new image (e.g. `rhel-coreos` as part of layering) and this will avoid a tedious "ratching" process to plumb that through the installer. Now the MCO can just directly read the image references.
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
(Draft since this is not tested yet, also this is a good time to object or propose a different plan) |
staebler
left a comment
staebler
left a comment
There was a problem hiding this comment.
This seems like a reasonable approach to me. I like the idea of pushing the domain knowledge of which images MCO is using to the MCO repo, instead of having it in the installer repo.
|
/cc @patrickdillon |
openshift-ci
Bot
requested review from
patrickdillon
and removed request for
jstuever and
kirankt
|
@cgwalters: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/close in favor of #6234 |
|
@patrickdillon: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
Depends: openshift/machine-config-operator#3017
I want to add a new image (e.g.
rhel-coreosas part of layering)and this will avoid a tedious "ratching" process to plumb that
through the installer. Now the MCO can just directly read the image
references.