Bug 2086936: vSphere: change socket back to cores

[jcpowermac]

Virtual machines running on
vSphere should be configured for cores
over sockets for NUMA. The change
in #5841 missed that.

Changing vSphere back to using a single
socket and multiple cores.

[jcpowermac]

ptal
@patrickdillon
@rna-afk

https://blogs.vmware.com/performance/2017/03/virtual-machine-vcpu-and-vnuma-rightsizing-rules-of-thumb.html
and
#5001

[jcpowermac]

In vSphere:

NumCPUs / NumCoresPerSocket = socket count

[openshift-ci]

@jcpowermac: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi	bc42579	link	false	/test e2e-metal-ipi
ci/prow/e2e-crc	bc42579	link	false	/test e2e-crc
ci/prow/e2e-ibmcloud	bc42579	link	false	/test e2e-ibmcloud
ci/prow/e2e-metal-assisted	bc42579	link	false	/test e2e-metal-assisted
ci/prow/okd-e2e-aws	bc42579	link	false	/test okd-e2e-aws
ci/prow/e2e-libvirt	bc42579	link	false	/test e2e-libvirt
ci/prow/e2e-ovirt	bc42579	link	false	/test e2e-ovirt
ci/prow/e2e-gcp	bc42579	link	false	/test e2e-gcp
ci/prow/e2e-vsphere	bc42579	link	false	/test e2e-vsphere

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[patrickdillon]

This is only affecting compute nodes, right? I believe this value is already 4 for control plane. The reason I felt comfortable with setting the 1 for NumCoresPerSocket is because that is the value used in CI: https://github.com/openshift/release/blob/master/ci-operator/step-registry/ipi/conf/vsphere/ipi-conf-vsphere-commands.sh#L57

I definitely defer to your judgment. Also, @rna-afk had this set to 4 before I questioned him about it.

[patrickdillon]

/approve

@jcpowermac would you mind creating a bz for this?

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jcpowermac]

This is only affecting compute nodes, right? I believe this value is already 4 for control plane. The reason I felt comfortable with setting the 1 for NumCoresPerSocket is because that is the value used in CI: https://github.com/openshift/release/blob/master/ci-operator/step-registry/ipi/conf/vsphere/ipi-conf-vsphere-commands.sh#L57

Yeah I should have updated it after #5001

[jcpowermac]

/approve

@jcpowermac would you mind creating a bz for this?

Sure

[openshift-ci]

@jcpowermac: This pull request references Bugzilla bug 2086936, which is invalid:

• expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2086936: vSphere: change socket back to cores

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jcpowermac]

/bugzilla refresh

[openshift-ci]

@jcpowermac: This pull request references Bugzilla bug 2086936, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.11.0) matches configured target release for branch (4.11.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gpei@redhat.com), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[patrickdillon]

/lgtm

[openshift-ci]

@jcpowermac: All pull requests linked via external trackers have merged:

• openshift/installer#5914

Bugzilla bug 2086936 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2086936: vSphere: change socket back to cores

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.