Skip to content

vSphere Zonal: Force tag cat names#6273

Closed
jcpowermac wants to merge 1 commit intoopenshift:masterfrom
jcpowermac:vsphere_force_tag_cat_zonal
Closed

vSphere Zonal: Force tag cat names#6273
jcpowermac wants to merge 1 commit intoopenshift:masterfrom
jcpowermac:vsphere_force_tag_cat_zonal

Conversation

@jcpowermac
Copy link
Copy Markdown
Contributor

This PR changes tag category naming for zonal from
a definable option to forced defined

  • openshift-region
  • openshift-zone

This PR changes tag category naming for zonal from
a definable option to forced defined

- openshift-region
- openshift-zone
@jcpowermac
Copy link
Copy Markdown
Contributor Author

Need to change the platform spec as well.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 29, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jcpowermac by writing /assign @jcpowermac in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 29, 2022

@jcpowermac: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@barbacbd
Copy link
Copy Markdown
Contributor

barbacbd commented Sep 6, 2022

/uncc

@openshift-ci openshift-ci Bot removed the request for review from barbacbd September 6, 2022 19:24
@jcpowermac
Copy link
Copy Markdown
Contributor Author

/close

A new pr will replace this.

@openshift-ci openshift-ci Bot closed this Sep 7, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 7, 2022

@jcpowermac: Closed this PR.

Details

In response to this:

/close

A new pr will replace this.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants