Skip to content

[WIP] Increase agent wait-for bootstrap timeout#6360

Closed
andfasano wants to merge 1 commit intoopenshift:masterfrom
andfasano:agent-increase-bootstrap-timeout
Closed

[WIP] Increase agent wait-for bootstrap timeout#6360
andfasano wants to merge 1 commit intoopenshift:masterfrom
andfasano:agent-increase-bootstrap-timeout

Conversation

@andfasano
Copy link
Copy Markdown
Contributor

/draft

Just for testing, not to be merged

@andfasano andfasano changed the title Increase agent wait-for bootstrap timeout [WIP] Increase agent wait-for bootstrap timeout Sep 15, 2022
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 15, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 15, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from andfasano by writing /assign @andfasano in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zaneb
Copy link
Copy Markdown
Member

zaneb commented Sep 15, 2022

/test ?

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 15, 2022

@zaneb: The following commands are available to trigger required jobs:

  • /test aro-unit
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-upi
  • /test e2e-azure-ovn
  • /test e2e-azure-ovn-upi
  • /test e2e-gcp-ovn
  • /test e2e-gcp-ovn-upi
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-vsphere-ovn
  • /test e2e-vsphere-upi
  • /test gofmt
  • /test golint
  • /test govet
  • /test images
  • /test okd-images
  • /test okd-unit
  • /test okd-verify-codegen
  • /test openstack-manifests
  • /test shellcheck
  • /test tf-lint
  • /test unit
  • /test verify-codegen
  • /test verify-vendor
  • /test yaml-lint

The following commands are available to trigger optional jobs:

  • /test e2e-agent-compact
  • /test e2e-alibaba
  • /test e2e-aws-disruptive
  • /test e2e-aws-ovn-fips
  • /test e2e-aws-ovn-imdsv2
  • /test e2e-aws-ovn-proxy
  • /test e2e-aws-ovn-shared-vpc
  • /test e2e-aws-ovn-single-node
  • /test e2e-aws-upgrade
  • /test e2e-aws-upi-proxy
  • /test e2e-aws-workers-rhel8
  • /test e2e-azure-ovn-resourcegroup
  • /test e2e-azure-ovn-shared-vpc
  • /test e2e-azurestack
  • /test e2e-azurestack-upi
  • /test e2e-crc
  • /test e2e-gcp-ovn-shared-vpc
  • /test e2e-gcp-upgrade
  • /test e2e-gcp-upi-xpn
  • /test e2e-ibmcloud-ovn
  • /test e2e-libvirt
  • /test e2e-metal-assisted
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-swapped-hosts
  • /test e2e-metal-ipi-virtualmedia
  • /test e2e-metal-single-node-live-iso
  • /test e2e-nutanix
  • /test e2e-openstack
  • /test e2e-openstack-kuryr
  • /test e2e-openstack-parallel
  • /test e2e-openstack-proxy
  • /test e2e-openstack-upi
  • /test e2e-ovirt
  • /test e2e-vsphere-zones
  • /test okd-e2e-aws-ovn
  • /test okd-e2e-aws-upgrade
  • /test okd-e2e-gcp
  • /test okd-e2e-gcp-ovn-upgrade
  • /test okd-e2e-vsphere
  • /test tf-fmt

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-installer-master-aro-unit
  • pull-ci-openshift-installer-master-e2e-agent-compact
  • pull-ci-openshift-installer-master-e2e-aws-ovn
  • pull-ci-openshift-installer-master-e2e-metal-assisted
  • pull-ci-openshift-installer-master-gofmt
  • pull-ci-openshift-installer-master-golint
  • pull-ci-openshift-installer-master-govet
  • pull-ci-openshift-installer-master-images
  • pull-ci-openshift-installer-master-okd-e2e-aws-ovn
  • pull-ci-openshift-installer-master-okd-e2e-gcp-ovn-upgrade
  • pull-ci-openshift-installer-master-okd-images
  • pull-ci-openshift-installer-master-okd-unit
  • pull-ci-openshift-installer-master-okd-verify-codegen
  • pull-ci-openshift-installer-master-shellcheck
  • pull-ci-openshift-installer-master-tf-fmt
  • pull-ci-openshift-installer-master-tf-lint
  • pull-ci-openshift-installer-master-unit
  • pull-ci-openshift-installer-master-verify-codegen
  • pull-ci-openshift-installer-master-verify-vendor
  • pull-ci-openshift-installer-master-yaml-lint
Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zaneb
Copy link
Copy Markdown
Member

zaneb commented Sep 15, 2022

/test e2e-agent-compact

@bfournie
Copy link
Copy Markdown
Contributor

FYI - I've been running with this same change in my local dev-scripts setup for weeks now. It was the only way I could get the IPv6 test to pass. Without this change it was failing 100% of the time and with it, it passes every time.

@lranjbar
Copy link
Copy Markdown
Contributor

This could be hardware dependent. In my local testing bootstrap takes around 20 mins, but I had originally a longer timeout to account for some buffer. IMHO it is fine to increase it.

@zaneb
Copy link
Copy Markdown
Member

zaneb commented Sep 16, 2022

#6362 seems to make it clear that the cause is a regression in assisted-service, but it's still surprising that this increase in timeout would cause the whole test to hit the 4 hour limit, so let's see if it happens again.
/test e2e-agent-compact

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 16, 2022

@andfasano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn 9d24c4c link true /test e2e-aws-ovn
ci/prow/e2e-vsphere-ovn 9d24c4c link true /test e2e-vsphere-ovn
ci/prow/e2e-gcp-ovn 9d24c4c link true /test e2e-gcp-ovn
ci/prow/okd-e2e-gcp-ovn-upgrade 9d24c4c link false /test okd-e2e-gcp-ovn-upgrade
ci/prow/e2e-ibmcloud-ovn 9d24c4c link false /test e2e-ibmcloud-ovn
ci/prow/e2e-azure-ovn 9d24c4c link true /test e2e-azure-ovn
ci/prow/e2e-agent-compact 9d24c4c link false /test e2e-agent-compact
ci/prow/e2e-libvirt 9d24c4c link false /test e2e-libvirt

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andfasano
Copy link
Copy Markdown
Contributor Author

Looks like the problem was due a conflict check for schedulable master manifests(between assisted service and installer), so closing this PR

@andfasano andfasano closed this Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants