Skip to content

OpenStack: Store ignition file in Swift when the upload in Glance fails#6431

Closed
eramoto wants to merge 1 commit intoopenshift:masterfrom
eramoto:use-swift-for-ignition
Closed

OpenStack: Store ignition file in Swift when the upload in Glance fails#6431
eramoto wants to merge 1 commit intoopenshift:masterfrom
eramoto:use-swift-for-ignition

Conversation

@eramoto
Copy link
Copy Markdown
Contributor

@eramoto eramoto commented Sep 29, 2022

Some openstack environments do not allow users to upload or download image data. This is because the cloud providers prevent them from using illegal images on the openstack or getting proprietary images on a local.

This PR is based on the Swift functions removed in PR #2960 and adds the feature to store a ignition file in Swift when an upload in Glance fails, as follows:

Glance enable Swift enable used storage
v v Glance
v Glance
v Swift <- this PR
none

Some openstack environments do not allow users to upload or download image data.
This is because the cloud providers prevent them from using illegal images on
the openstack or getting proprietary images on a local.

This PR is based on the Swift functions removed in PR openshift#2960 and adds the feature
to store a ignition file in Swift when an upload in Glance fails, as follows:

   Glance | Swift  | used
   enable | enable | storage
  --------+--------+---------
      v   |   v    | Glance
      v   |        | Glance
          |   v    | Swift   <- this PR
          |        | none

Signed-off-by: ERAMOTO Masaya <eramoto.masaya@jp.fujitsu.com>
@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 29, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 29, 2022

Hi @eramoto. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 29, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign annazivkovic for approval by writing /assign @annazivkovic in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot requested review from gryf and r4f4 September 29, 2022 09:51
@sadasu
Copy link
Copy Markdown
Contributor

sadasu commented Oct 11, 2022

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 11, 2022
@eramoto
Copy link
Copy Markdown
Contributor Author

eramoto commented Oct 14, 2022

/retest-required

@eramoto
Copy link
Copy Markdown
Contributor Author

eramoto commented Oct 20, 2022

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 19, 2022
@openshift-merge-robot
Copy link
Copy Markdown
Contributor

@eramoto: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 12, 2023

@eramoto: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-parallel 6c01e2f link false /test e2e-openstack-parallel
ci/prow/e2e-metal-ipi 6c01e2f link false /test e2e-metal-ipi
ci/prow/e2e-ibmcloud-ovn 6c01e2f link false /test e2e-ibmcloud-ovn
ci/prow/e2e-openstack-sdn-parallel 6c01e2f link false /test e2e-openstack-sdn-parallel
ci/prow/okd-scos-e2e-aws-upgrade 6c01e2f link false /test okd-scos-e2e-aws-upgrade
ci/prow/e2e-libvirt 6c01e2f link false /test e2e-libvirt
ci/prow/okd-scos-e2e-aws-ovn 6c01e2f link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-metal-ipi-sdn 6c01e2f link false /test e2e-metal-ipi-sdn
ci/prow/e2e-openstack-proxy 6c01e2f link false /test e2e-openstack-proxy
ci/prow/e2e-agent-compact-ipv4 6c01e2f link true /test e2e-agent-compact-ipv4
ci/prow/agent-integration-tests 6c01e2f link true /test agent-integration-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Copy Markdown
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 13, 2023
@openshift-bot
Copy link
Copy Markdown
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci Bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 13, 2023
@openshift-bot
Copy link
Copy Markdown
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci Bot closed this Jun 13, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 13, 2023

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants