Skip to content

openstack: Allow BGP to route traffic to API#6440

Closed
pierreprinetti wants to merge 7 commits into
openshift:masterfrom
shiftstack:os_bgp
Closed

openstack: Allow BGP to route traffic to API#6440
pierreprinetti wants to merge 7 commits into
openshift:masterfrom
shiftstack:os_bgp

Conversation

@pierreprinetti
Copy link
Copy Markdown
Contributor

@pierreprinetti pierreprinetti commented Sep 30, 2022

as an alternative to keepalived/haproxy

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 30, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 30, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Sep 30, 2022

/test verify-codegen

@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Sep 30, 2022

/test openstack-manifest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 30, 2022

@pierreprinetti: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test aro-unit
  • /test e2e-agent-compact
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-upi
  • /test e2e-azure-ovn
  • /test e2e-azure-ovn-upi
  • /test e2e-gcp-ovn
  • /test e2e-gcp-ovn-upi
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-vsphere-ovn
  • /test e2e-vsphere-upi
  • /test gofmt
  • /test golint
  • /test govet
  • /test images
  • /test okd-images
  • /test okd-unit
  • /test okd-verify-codegen
  • /test openstack-manifests
  • /test shellcheck
  • /test tf-lint
  • /test unit
  • /test verify-codegen
  • /test verify-vendor
  • /test yaml-lint

The following commands are available to trigger optional jobs:

  • /test e2e-agent-mce
  • /test e2e-alibaba
  • /test e2e-aws-disruptive
  • /test e2e-aws-ovn-fips
  • /test e2e-aws-ovn-imdsv2
  • /test e2e-aws-ovn-proxy
  • /test e2e-aws-ovn-shared-vpc
  • /test e2e-aws-ovn-single-node
  • /test e2e-aws-upgrade
  • /test e2e-aws-upi-proxy
  • /test e2e-aws-workers-rhel8
  • /test e2e-azure-ovn-resourcegroup
  • /test e2e-azure-ovn-shared-vpc
  • /test e2e-azurestack
  • /test e2e-azurestack-upi
  • /test e2e-crc
  • /test e2e-gcp-ovn-shared-vpc
  • /test e2e-gcp-upgrade
  • /test e2e-gcp-upi-xpn
  • /test e2e-ibmcloud-ovn
  • /test e2e-libvirt
  • /test e2e-metal-assisted
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-swapped-hosts
  • /test e2e-metal-ipi-virtualmedia
  • /test e2e-metal-single-node-live-iso
  • /test e2e-nutanix
  • /test e2e-openstack
  • /test e2e-openstack-kuryr
  • /test e2e-openstack-parallel
  • /test e2e-openstack-proxy
  • /test e2e-openstack-upi
  • /test e2e-ovirt
  • /test e2e-vsphere-zones
  • /test okd-e2e-aws-ovn
  • /test okd-e2e-aws-upgrade
  • /test okd-e2e-gcp
  • /test okd-e2e-gcp-ovn-upgrade
  • /test okd-e2e-vsphere
  • /test tf-fmt

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-installer-master-aro-unit
  • pull-ci-openshift-installer-master-e2e-agent-compact
  • pull-ci-openshift-installer-master-e2e-agent-mce
  • pull-ci-openshift-installer-master-e2e-aws-ovn
  • pull-ci-openshift-installer-master-e2e-aws-ovn-fips
  • pull-ci-openshift-installer-master-e2e-aws-ovn-imdsv2
  • pull-ci-openshift-installer-master-e2e-aws-ovn-proxy
  • pull-ci-openshift-installer-master-e2e-aws-ovn-shared-vpc
  • pull-ci-openshift-installer-master-e2e-aws-ovn-single-node
  • pull-ci-openshift-installer-master-e2e-azure-ovn
  • pull-ci-openshift-installer-master-e2e-azure-ovn-resourcegroup
  • pull-ci-openshift-installer-master-e2e-azure-ovn-shared-vpc
  • pull-ci-openshift-installer-master-e2e-azurestack
  • pull-ci-openshift-installer-master-e2e-gcp-ovn
  • pull-ci-openshift-installer-master-e2e-ibmcloud-ovn
  • pull-ci-openshift-installer-master-e2e-libvirt
  • pull-ci-openshift-installer-master-e2e-metal-assisted
  • pull-ci-openshift-installer-master-e2e-metal-ipi
  • pull-ci-openshift-installer-master-e2e-openstack
  • pull-ci-openshift-installer-master-e2e-openstack-kuryr
  • pull-ci-openshift-installer-master-e2e-openstack-parallel
  • pull-ci-openshift-installer-master-e2e-openstack-proxy
  • pull-ci-openshift-installer-master-e2e-ovirt
  • pull-ci-openshift-installer-master-e2e-vsphere-ovn
  • pull-ci-openshift-installer-master-gofmt
  • pull-ci-openshift-installer-master-golint
  • pull-ci-openshift-installer-master-govet
  • pull-ci-openshift-installer-master-images
  • pull-ci-openshift-installer-master-okd-e2e-aws-ovn
  • pull-ci-openshift-installer-master-okd-e2e-aws-upgrade
  • pull-ci-openshift-installer-master-okd-images
  • pull-ci-openshift-installer-master-okd-unit
  • pull-ci-openshift-installer-master-okd-verify-codegen
  • pull-ci-openshift-installer-master-openstack-manifests
  • pull-ci-openshift-installer-master-shellcheck
  • pull-ci-openshift-installer-master-tf-fmt
  • pull-ci-openshift-installer-master-tf-lint
  • pull-ci-openshift-installer-master-unit
  • pull-ci-openshift-installer-master-verify-codegen
  • pull-ci-openshift-installer-master-verify-vendor
  • pull-ci-openshift-installer-master-yaml-lint
Details

In response to this:

/test openstack-manifest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Sep 30, 2022

/test openstack-manifests

@pierreprinetti pierreprinetti force-pushed the os_bgp branch 3 times, most recently from f764279 to 627df83 Compare September 30, 2022 18:06
@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Sep 30, 2022

/test openstack-manifests

@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Sep 30, 2022

/test openstack-manifests

@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Sep 30, 2022

/test openstack-manifests

@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Sep 30, 2022

/test verify-codegen

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 1, 2022
@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Oct 1, 2022

/test verify-codegen

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 1, 2022
@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Oct 1, 2022

/test verify-codegen openstack-manifests

@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Oct 4, 2022

/test verify-codegen openstack-manifests

@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Oct 6, 2022

/test verify-codegen openstack-manifests e2e-openstack

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 11, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 19, 2022
@pierreprinetti
Copy link
Copy Markdown
Contributor Author

pierreprinetti commented Oct 19, 2022

/test verify-codegen openstack-manifests e2e-openstack

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 19, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign annazivkovic for approval by writing /assign @annazivkovic in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@EmilienM EmilienM force-pushed the os_bgp branch 2 times, most recently from feb1bf3 to c1fbfb7 Compare November 17, 2022 14:46
@EmilienM EmilienM force-pushed the os_bgp branch 7 times, most recently from e2541ec to 93a2d6a Compare December 3, 2022 13:35
pierreprinetti and others added 6 commits December 13, 2022 21:05
@pierreprinetti @EmilienM
Use a fork of openshift/api
0cfbadb 
to import OpenStackAPILoadBalancer from there
@pierreprinetti @EmilienM
openstack: Allow BGP to route traffic to API
7f55603 
as an alternative to keepalived/haproxy

Co-authored-by: Emilien Macchi <emilien@redhat.com>
Co-authored-by: Pierre Prinetti <pierreprinetti@redhat.com>
@pierreprinetti @EmilienM
don't create the API VIP port if lbtype==BGP
1c5ca79
@EmilienM
Bump openshift/api to a rebased version of the PR
cab9cfd
@EmilienM
WIP - change terraform to not create ports when BGP is used
51b6178 
I marked it as WIP until this comment is resolved:
openshift#6440 (comment)
@EmilienM
Update vendoring for API
0317b35
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 19, 2022
@openshift-merge-robot
Copy link
Copy Markdown
Contributor

openshift-merge-robot commented Dec 19, 2022

@pierreprinetti: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 12, 2023

@pierreprinetti: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-verify-codegen f6797e2282b9c6f6cc148f32530321158a1df306 link true /test okd-scos-verify-codegen
ci/prow/okd-scos-unit f6797e2282b9c6f6cc148f32530321158a1df306 link true /test okd-scos-unit
ci/prow/okd-scos-images f6797e2282b9c6f6cc148f32530321158a1df306 link true /test okd-scos-images
ci/prow/verify-codegen 23ae22b62d717cc010c944b6b3b0e7faa1b8f983 link true /test verify-codegen
ci/prow/openstack-manifests 23ae22b62d717cc010c944b6b3b0e7faa1b8f983 link true /test openstack-manifests
ci/prow/e2e-openstack 23ae22b62d717cc010c944b6b3b0e7faa1b8f983 link false /test e2e-openstack
ci/prow/e2e-agent-compact-ipv4 6b7f428 link true /test e2e-agent-compact-ipv4
ci/prow/agent-integration-tests 6b7f428 link true /test agent-integration-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@EmilienM
Copy link
Copy Markdown
Member

EmilienM commented Jan 27, 2023

/close
We are doing External LB instead.

@openshift-ci openshift-ci Bot closed this Jan 27, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 27, 2023

@EmilienM: Closed this PR.

Details

In response to this:

/close
We are doing External LB instead.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@EmilienM
Copy link
Copy Markdown
Member

EmilienM commented Jan 27, 2023

#6812

@stephenfin stephenfin deleted the os_bgp branch November 18, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pierreprinetti @EmilienM @openshift-merge-robot