pkg/asset/releaseimage/pullspec: Include override pullspec in log message#6460
Conversation
…sage This code-branch should be very rare, probably mostly internal testing. A chattier line in those situations isn't a big user-experience concern, and including the pullspec makes it easier for folks who are trying to understand internal-test results to figure out which pullspec was being used. The log line is originally from 456a373 (pkg: Use the sources from InstalConfig to create containers-registries.conf for bootstap, 2019-06-28, openshift#1910), and it was tweaked in cd0b70f (asset: Make warning message read for humans, 2019-09-15, openshift#2361), and neither of those make explicit arguments for why they didn't include the pullspec.
|
/lgtm |
|
/approve |
openshift-ci
Bot
added
the
approved
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhixson74, patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
6 participants
This code-branch should be very rare, probably mostly internal testing. A chattier line in those situations isn't a big user-experience concern, and including the pullspec makes it easier for folks who are trying to understand internal-test results to figure out which pullspec was being used.
The log line is originally from 456a373 (#1910), and it was tweaked in cd0b70f (#2361), and neither of those make explicit arguments for why they didn't include the pullspec.