[release-4.11] OCPBUGS-5078: OpenStack: Force JSON content-type in Swift object listing by openshift-cherrypick-robot · Pull Request #6725 · openshift/installer

openshift-cherrypick-robot · 2022-12-20T19:42:10Z

This is an automated cherry-pick of #6718

/assign pierreprinetti

Some OpenStack object storages respond with `204 No Content` to list requests when there are no containers or objects to list. In these cases, when responding to requests with an `Accept: text/plain` or no `Accept` header, some object storages omit the `content-type` header in their status-204 responses. Now, Gophercloud throws an error when the response does not contain a `content-type` header. With this change, we work around the issue by forcing Gophercloud to request a JSON response from the object storage when listing objects. When passed an `Accept: application/json` header, the server responds with `200 Ok` and a `content-type` header in our tests. This solution gives us a fix that is easily backportable because it doesn't require any dependency bump.

openshift-ci-robot · 2022-12-20T19:42:17Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-5019 has been cloned as Jira Issue OCPBUGS-5078. Retitling PR to link against new bug.
/retitle [release-4.11] OCPBUGS-5078: OpenStack: Force JSON content-type in Swift object listing

Details

In response to this:

This is an automated cherry-pick of #6718

/assign pierreprinetti

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2022-12-20T19:43:56Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-5078, which is invalid:

expected dependent Jira Issue OCPBUGS-5019 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #6718

/assign pierreprinetti

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti · 2022-12-20T19:43:57Z

/cherry-pick release-4.10

openshift-cherrypick-robot · 2022-12-20T19:43:58Z

@pierreprinetti: once the present PR merges, I will cherry-pick it on top of release-4.10 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-12-20T19:44:00Z

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.11] OCPBUGS-5078: OpenStack: Force JSON content-type in Swift object listing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti · 2022-12-20T22:58:35Z

/test e2e-openstack

pierreprinetti · 2022-12-21T08:45:11Z

/jira refresh
/lgtm

openshift-ci-robot · 2022-12-21T08:45:17Z

@pierreprinetti: This pull request references Jira Issue OCPBUGS-5078, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.11.z) matches configured target version for branch (4.11.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-5019 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
dependent Jira Issue OCPBUGS-5019 targets the "4.12.0" version, which is one of the valid target versions: 4.12.0
bug has dependents

Requesting review from QA contact:
/cc @eurijon

Details

In response to this:

/jira refresh
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti · 2022-12-21T08:49:01Z

/test e2e-openstack

pierreprinetti · 2022-12-21T08:49:33Z

/hold for the test
CC @mandre @eurijon for the usual labels

mandre

/lgtm
/approve
/label backport-risk-assessed

openshift-ci · 2022-12-21T09:24:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre, pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~pkg/destroy/openstack/OWNERS~~ [mandre,pierreprinetti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pierreprinetti · 2022-12-21T12:46:13Z

ipi-deprovision-deprovision succeeded in e2e-openstack.

pierreprinetti · 2022-12-21T12:46:29Z

/hold cancel

mandre · 2022-12-21T12:50:03Z

ipi-deprovision-deprovision succeeded in e2e-openstack.

It's expected, because CIRO falls back to cinder in 4.11 for the jobs that run on vexxhost (we haven't backported the CIRO change past 4.12 I believe - we don't really have reasons to).

eurijon · 2022-12-21T12:53:40Z

/label cherry-pick-approved

openshift-ci · 2022-12-21T13:53:33Z

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-upi-proxy	`db4b47b`	link	false	`/test e2e-aws-upi-proxy`
ci/prow/e2e-openstack	`db4b47b`	link	false	`/test e2e-openstack`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2022-12-21T13:57:39Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

openshift/installer#6725

Jira Issue OCPBUGS-5078 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #6718

/assign pierreprinetti

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2022-12-21T13:58:44Z

@pierreprinetti: new pull request created: #6726

Details

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci Bot assigned pierreprinetti Dec 20, 2022

openshift-cherrypick-robot mentioned this pull request Dec 20, 2022

[release-4.12] OCPBUGS-5019: OpenStack: Force JSON content-type in Swift object listing #6718

Merged

pierreprinetti approved these changes Dec 20, 2022

View reviewed changes

openshift-ci Bot changed the title ~~[release-4.11] OCPBUGS-5019: OpenStack: Force JSON content-type in Swift object listing~~ [release-4.11] OCPBUGS-5078: OpenStack: Force JSON content-type in Swift object listing Dec 20, 2022

openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 20, 2022

openshift-ci Bot requested review from gryf and mdbooth December 20, 2022 19:44

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2022

openshift-ci Bot requested a review from eurijon December 21, 2022 08:45

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2022

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 21, 2022

mandre reviewed Dec 21, 2022

View reviewed changes

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Dec 21, 2022

openshift-ci Bot assigned mandre Dec 21, 2022

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 21, 2022

openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 21, 2022

openshift-merge-robot merged commit 6beb6c0 into openshift:release-4.11 Dec 21, 2022

openshift-cherrypick-robot mentioned this pull request Dec 21, 2022

[release-4.10] OCPBUGS-5112: OpenStack: Force JSON content-type in Swift object listing #6726

Merged

Conversation

openshift-cherrypick-robot commented Dec 20, 2022

Uh oh!

openshift-ci-robot commented Dec 20, 2022

Uh oh!

openshift-ci-robot commented Dec 20, 2022

Uh oh!

pierreprinetti commented Dec 20, 2022

Uh oh!

openshift-cherrypick-robot commented Dec 20, 2022

Uh oh!

openshift-ci Bot commented Dec 20, 2022

Uh oh!

pierreprinetti commented Dec 20, 2022

Uh oh!

pierreprinetti commented Dec 21, 2022

Uh oh!

openshift-ci-robot commented Dec 21, 2022

Uh oh!

pierreprinetti commented Dec 21, 2022

Uh oh!

pierreprinetti commented Dec 21, 2022

Uh oh!

mandre left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Dec 21, 2022

Uh oh!

pierreprinetti commented Dec 21, 2022

Uh oh!

pierreprinetti commented Dec 21, 2022

Uh oh!

mandre commented Dec 21, 2022

Uh oh!

eurijon commented Dec 21, 2022

Uh oh!

openshift-ci Bot commented Dec 21, 2022

Uh oh!

openshift-ci-robot commented Dec 21, 2022

Uh oh!

openshift-cherrypick-robot commented Dec 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants