Skip to content

OSASINFRA-3075 - openstack: external LB support#6758

Closed
EmilienM wants to merge 6 commits into
openshift:masterfrom
shiftstack:osp-external-lb
Closed

OSASINFRA-3075 - openstack: external LB support#6758
EmilienM wants to merge 6 commits into
openshift:masterfrom
shiftstack:osp-external-lb

Conversation

@EmilienM
Copy link
Copy Markdown
Member

This includes commits that will help to support External Load-Balancer
for the OpenStack platform:

  • openstack: add condition to configure VIPs in PlatformStatus
  • openstack: validate dns and external load balancer

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 10, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 10, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sadasu for approval by writing /assign @sadasu in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@EmilienM EmilienM changed the title WIP - openstack: external LB support OSASINFRA-3075 - openstack: external LB support Jan 18, 2023
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 18, 2023
When the VIP parameters within the Infrastructure Status object
are empty, MCO will not deploy the internal LB for on-prem
(HAproxy/Keepalived).

This allows to use an external Load-Balancer instead of the internal
one.
This PR adds validation to the OpenStack installation for DNS and LB
existence.

It will query DNS for api and api-int. If either fail a error will be provided.

It will perform a TCP/6443 port connection to the api.ClusterDomain(). If not
available will emit a warning only.

We are re-using the function from vsphere/validation (we had to make it
public).
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 26, 2023

@EmilienM: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-workers-rhel8 eaf0da6 link false /test e2e-aws-ovn-workers-rhel8
ci/prow/aro-unit eaf0da6 link true /test aro-unit
ci/prow/okd-e2e-aws-ovn eaf0da6 link false /test okd-e2e-aws-ovn
ci/prow/e2e-vsphere-ovn eaf0da6 link true /test e2e-vsphere-ovn
ci/prow/okd-scos-e2e-aws-ovn eaf0da6 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-openstack-kuryr eaf0da6 link false /test e2e-openstack-kuryr
ci/prow/tf-fmt eaf0da6 link false /test tf-fmt
ci/prow/e2e-aws-ovn-disruptive eaf0da6 link false /test e2e-aws-ovn-disruptive
ci/prow/e2e-openstack-ovn eaf0da6 link true /test e2e-openstack-ovn
ci/prow/okd-unit eaf0da6 link true /test okd-unit
ci/prow/unit eaf0da6 link true /test unit
ci/prow/okd-e2e-aws-ovn-upgrade eaf0da6 link false /test okd-e2e-aws-ovn-upgrade
ci/prow/okd-scos-unit eaf0da6 link false /test okd-scos-unit
ci/prow/okd-scos-e2e-aws-upgrade eaf0da6 link false /test okd-scos-e2e-aws-upgrade
ci/prow/e2e-aws-ovn eaf0da6 link true /test e2e-aws-ovn
ci/prow/e2e-openstack-proxy eaf0da6 link false /test e2e-openstack-proxy
ci/prow/e2e-vsphere-upi-zones eaf0da6 link false /test e2e-vsphere-upi-zones
ci/prow/e2e-openstack-sdn-parallel eaf0da6 link false /test e2e-openstack-sdn-parallel

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@EmilienM
Copy link
Copy Markdown
Member Author

/close
taken over by #6812

@openshift-ci openshift-ci Bot closed this Jan 27, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 27, 2023

@EmilienM: Closed this PR.

Details

In response to this:

/close
taken over by #6812

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stephenfin stephenfin deleted the osp-external-lb branch November 18, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant