test jenkins webhooks#7
Closed
paulfantom wants to merge 2 commits intomasterfrom
Closed
Conversation
openshift-ci-robot
added
the
size/XS
Contributor
Author
|
ok to test |
Contributor
|
@paulfantom: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
Author
|
ok to test |
stbenjam
pushed a commit
to stbenjam/installer
that referenced
this pull request
Apr 30, 2019
baremetal: prefix resources with cluster_id
BobbyRadford
added a commit
to BobbyRadford/installer
that referenced
this pull request
May 10, 2021
Add the MachinePool Type and Validation
mkumatag
pushed a commit
to mkumatag/installer
that referenced
this pull request
Jun 24, 2021
* Added machines asset for Power VS platform * This commit has 1. Go mod vendor changes, go mod tidy changes, machine pool variable rename in accordance with Power VS provider machine config name changes
clnperez
pushed a commit
to clnperez/installer
that referenced
this pull request
Jul 16, 2021
* Added machines asset for Power VS platform * This commit has 1. Go mod vendor changes, go mod tidy changes, machine pool variable rename in accordance with Power VS provider machine config name changes
clnperez
pushed a commit
to clnperez/installer
that referenced
this pull request
Jul 20, 2021
* Added machines asset for Power VS platform * This commit has 1. Go mod vendor changes, go mod tidy changes, machine pool variable rename in accordance with Power VS provider machine config name changes
clnperez
pushed a commit
to clnperez/installer
that referenced
this pull request
Jul 22, 2021
* Added machines asset for Power VS platform * This commit has 1. Go mod vendor changes, go mod tidy changes, machine pool variable rename in accordance with Power VS provider machine config name changes
clnperez
pushed a commit
to clnperez/installer
that referenced
this pull request
Sep 2, 2021
* Added machines asset for Power VS platform * This commit has 1. Go mod vendor changes, go mod tidy changes, machine pool variable rename in accordance with Power VS provider machine config name changes
zaneb
pushed a commit
to zaneb/openshift-installer
that referenced
this pull request
Apr 29, 2022
AGENT-37 Create cluster and infra-env using assisted-service REST-API
rvanderp3
referenced
this pull request
in openshift-splat-team/installer
Apr 14, 2026
Test coverage: - Single vCenter YAML credentials file reading - Multi-vCenter YAML credentials file reading - File permissions validation (reject 0644, 0777) - Precedence: install-config.yaml over credentials file - Partial precedence with fallback to credentials file - Missing credentials file fallback to legacy passthrough - Malformed YAML error handling - Empty credentials file handling - Partial component credentials with fallback All tests use t.Skip() for TDD approach. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
rvanderp3
referenced
this pull request
in openshift-splat-team/installer
Apr 14, 2026
Implements Story #7: Credentials File Support (YAML Format) This commit adds support for reading per-component vSphere credentials from a YAML credentials file at ~/.vsphere/credentials. The file uses YAML format with vCenter servers as top-level keys, each containing component-specific credential mappings. Key features: - YAML file format with vCenter FQDN as top-level keys - File permissions validation (must be 0600) - Precedence: install-config.yaml > credentials file > legacy passthrough - Graceful fallback when file doesn't exist or is empty - Support for single and multi-vCenter topologies - Partial component credentials with mixed sources Implementation: - pkg/asset/installconfig/vsphere/credentialsfile.go: Core parser and validator - pkg/asset/installconfig/vsphere/credentialsfile_test.go: 10 test scenarios All acceptance criteria verified: - AC1: YAML credentials file with correct permissions (0600) - AC2: File permissions validation (reject 0644, 0777) - AC3: Precedence (install-config over credentials file) Test coverage: 10/10 tests passing - Single vCenter YAML file reading - Multi-vCenter YAML file reading - Permissions rejection (0644, 0777) - Precedence (full and partial) - Missing file fallback - Malformed YAML error handling - Empty file fallback - Partial component coverage Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This was referenced Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Pull-requests for new features are no longer accepted in this repo. Only critical bug-fixes and security patches will be accepted.
See our blog for details:
https://coreos.com/blog/coreos-tech-to-combine-with-red-hat-openshift