[release-4.13] OCPBUGS-11261: Fix and improve locking session and AWS Metadata access by openshift-cherrypick-robot · Pull Request #7129 · openshift/installer

openshift-cherrypick-robot · 2023-04-25T14:11:33Z

This is an automated cherry-pick of #7070

/assign sadasu

This fix eliminates the need for mutexSubnets to update subnet information within AWS metadata. It also updates populateSubnets to take care of getting VPC and subnets once for the installation eliminating duplicate code that could be prone to errors. Co-authored-by: Rafael F. <r4f4rfs@gmail.com>

openshift-ci-robot · 2023-04-25T14:11:35Z

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-10767 with correct target version. Will retitle the PR to link to the clone.
/retitle [release-4.13] OCPBUGS-11261: Fix and improve locking session and AWS Metadata access

Details

In response to this:

This is an automated cherry-pick of #7070

/assign sadasu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-04-25T14:11:53Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-11261, which is invalid:

expected Jira Issue OCPBUGS-11261 to depend on a bug targeting a version in 4.14.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #7070

/assign sadasu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-04-25T14:12:21Z

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.13] OCPBUGS-11261: Fix and improve locking session and AWS Metadata access

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sadasu · 2023-04-25T14:26:42Z

/jira refresh

openshift-ci-robot · 2023-04-25T14:26:45Z

@sadasu: This pull request references Jira Issue OCPBUGS-11261, which is invalid:

expected Jira Issue OCPBUGS-11261 to depend on a bug targeting a version in 4.14.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sadasu · 2023-04-25T14:29:26Z

/jira refresh

openshift-ci-robot · 2023-04-25T14:29:29Z

@sadasu: This pull request references Jira Issue OCPBUGS-11261, which is invalid:

expected Jira Issue OCPBUGS-11261 to depend on a bug targeting a version in 4.14.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sadasu · 2023-04-25T14:30:55Z

/jira refresh

openshift-ci-robot · 2023-04-25T14:30:58Z

@sadasu: This pull request references Jira Issue OCPBUGS-11261, which is invalid:

expected Jira Issue OCPBUGS-11261 to depend on a bug targeting a version in 4.14.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sadasu · 2023-04-25T14:31:52Z

/jira refresh

openshift-ci-robot · 2023-04-25T14:31:54Z

@sadasu: This pull request references Jira Issue OCPBUGS-11261, which is invalid:

expected Jira Issue OCPBUGS-11261 to depend on a bug targeting a version in 4.14.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sadasu · 2023-04-25T14:33:40Z

/jira refresh

openshift-ci-robot · 2023-04-25T14:33:48Z

@sadasu: This pull request references Jira Issue OCPBUGS-11261, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.13.0) matches configured target version for branch (4.13.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-10767 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-10767 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (yunjiang@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

patrickdillon · 2023-04-25T14:49:20Z

/label backport-risk-assessed
/lgtm

openshift-ci · 2023-04-25T18:36:43Z

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-workers-rhel8	`c578602`	link	false	`/test e2e-aws-ovn-workers-rhel8`
ci/prow/e2e-aws-ovn-disruptive	`c578602`	link	false	`/test e2e-aws-ovn-disruptive`
ci/prow/e2e-aws-ovn-imdsv2	`c578602`	link	false	`/test e2e-aws-ovn-imdsv2`
ci/prow/e2e-aws-ovn-proxy	`c578602`	link	false	`/test e2e-aws-ovn-proxy`
ci/prow/e2e-aws-ovn-upgrade	`c578602`	link	false	`/test e2e-aws-ovn-upgrade`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

patrickdillon · 2023-04-25T19:59:06Z

/approve

openshift-ci · 2023-04-25T19:59:41Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~pkg/asset/installconfig/aws/OWNERS~~ [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jianlinliu · 2023-04-26T01:30:22Z

/label cherry-pick-approved

openshift-ci-robot · 2023-04-26T01:33:05Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-11261: All pull requests linked via external trackers have merged:

openshift/installer#7129

Jira Issue OCPBUGS-11261 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #7070

/assign sadasu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot · 2023-04-28T05:18:14Z

Fix included in accepted release 4.13.0-0.nightly-2023-04-27-232707

openshift-cherrypick-robot mentioned this pull request Apr 25, 2023

OCPBUGS-10767: Fix and improve locking session and AWS Metadata access #7070

Merged

openshift-ci Bot assigned sadasu Apr 25, 2023

openshift-ci Bot changed the title ~~[release-4.13] OCPBUGS-10767: Fix and improve locking session and AWS Metadata access~~ [release-4.13] OCPBUGS-11261: Fix and improve locking session and AWS Metadata access Apr 25, 2023

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 25, 2023

openshift-ci Bot requested review from mtulio and patrickdillon April 25, 2023 14:12

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 25, 2023

openshift-ci Bot assigned patrickdillon Apr 25, 2023

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2023

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2023

openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 26, 2023

openshift-merge-robot merged commit 1eae334 into openshift:release-4.13 Apr 26, 2023

Conversation

openshift-cherrypick-robot commented Apr 25, 2023

Uh oh!

openshift-ci-robot commented Apr 25, 2023

Uh oh!

openshift-ci-robot commented Apr 25, 2023

Uh oh!

openshift-ci Bot commented Apr 25, 2023

Uh oh!

sadasu commented Apr 25, 2023

Uh oh!

openshift-ci-robot commented Apr 25, 2023

Uh oh!

sadasu commented Apr 25, 2023

Uh oh!

openshift-ci-robot commented Apr 25, 2023

Uh oh!

sadasu commented Apr 25, 2023

Uh oh!

openshift-ci-robot commented Apr 25, 2023

Uh oh!

sadasu commented Apr 25, 2023

Uh oh!

openshift-ci-robot commented Apr 25, 2023

Uh oh!

sadasu commented Apr 25, 2023

Uh oh!

openshift-ci-robot commented Apr 25, 2023

Uh oh!

patrickdillon commented Apr 25, 2023

Uh oh!

openshift-ci Bot commented Apr 25, 2023

Uh oh!

patrickdillon commented Apr 25, 2023

Uh oh!

openshift-ci Bot commented Apr 25, 2023

Uh oh!

jianlinliu commented Apr 26, 2023

Uh oh!

openshift-ci-robot commented Apr 26, 2023

Uh oh!

openshift-merge-robot commented Apr 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants