Skip to content

Conversation

@mtnbikenc
Copy link
Member

$ bin/openshift-install version
bin/openshift-install v0.4.0-10-ge15d801ad69481da18d409bec5fa1c7bd7998f3a
Terraform v0.11.8

Your version of Terraform is out of date! The latest version
is 0.11.10. You can update by downloading from www.terraform.io/downloads.html

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mtnbikenc
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: staebler

If they are not already assigned, you can assign the PR to them by writing /assign @staebler in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 27, 2018
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should bump this to match. @sallyom, I think you have the keys to that repository. Can you push up a build for 0.11.10?

Looking through their changelog, I don't see anything that looks like it affects us. It's also been over a month since 0.11.10, so presumably any terrible bugs would have been flushed out by now ;). So I don't think we need to rush to get this landed, but it is nice to keep up with their current releases.

@mtnbikenc
Copy link
Member Author

Updated.

@openshift-ci-robot
Copy link
Contributor

@mtnbikenc: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt 6809b33 link /test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wking
Copy link
Member

wking commented Dec 5, 2018

@sallyom, I've assigned this to you, since it's just blocked on your pushing quay.io/coreos/terraform-alpine:v0.11.10.

Thoughts about moving your scripts-images under openshift/? Or enough for that one image under images/ in this repo? I'm fine sticking with buildah for it. We'd also need someone with push access to quay.io/coreos/terraform-alpine (or just quay.io/coreos/terraform, I'm fine with an image that just holds the terraform binary), but that would at least be a bigger pool than "@sallyom all by herself" ;).

@wking
Copy link
Member

wking commented Dec 13, 2018

Obsolete now that #822 has moved us to vendored Terraform Go.

/close

@openshift-ci-robot
Copy link
Contributor

@wking: Closed this PR.

Details

In response to this:

Obsolete now that #822 has moved us to vendored Terraform Go.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtnbikenc mtnbikenc deleted the bump-terraform branch December 13, 2018 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants