CORS-2660: GCP: deprecate the licenses field#7397
CORS-2660: GCP: deprecate the licenses field#7397openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@AnnaZivkovic: This pull request references CORS-2660 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @r4f4 |
r4f4
left a comment
r4f4
left a comment
There was a problem hiding this comment.
I was thinking about only marking the field as deprecated not removing the functionality itself (yet). If we can remove the functionality, great, but I'm afraid we might not be able to.
@patrickdillon Do you know?
There was a problem hiding this comment.
If you remove the creation of the image with the licenses in terraform, specifying any license in the install-config does nothing.
There was a problem hiding this comment.
Are you thinking we should just change the license field description and put out a warning if it is used?
There was a problem hiding this comment.
Yes, that's what I had in mind. We need to deprecate the field first, and then after a few releases we can remove.
There was a problem hiding this comment.
nit: would it be cleaner to do this assignment when calling provider so that the osImage argument is already the correct value?
There was a problem hiding this comment.
Then I think we have more duplicated code
|
Once we remove licenses, please make sure to update the epic & alert docs:
|
AnnaZivkovic
force-pushed
the
gcp_revert_licenses
branch
from
dcaf0b9 to
5d6dd2d
Compare
|
@AnnaZivkovic when I try to build using your branch, no binary is produced and I get the following error: Fixing that should fix the CI job failures. |
AnnaZivkovic
force-pushed
the
gcp_revert_licenses
branch
2 times, most recently
from
de59ad6 to
ab4bbaa
Compare
openshift-merge-robot
added
the
needs-rebase
It has been at leas two years since the licence field has become obsolete due RHCOS GCP images already having nested virt licences by default. The licenses field is being kept for backwards compatibility
AnnaZivkovic
force-pushed
the
gcp_revert_licenses
branch
from
ab4bbaa to
77234cc
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/retest-required |
|
/skip |
|
/override ci/prow/okd-images |
|
/override ci/prow/okd-scos-images |
|
@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/okd-images DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/okd-scos-images DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/okd-images |
|
@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/okd-images, ci/prow/okd-scos-images DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/okd-images |
|
@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/okd-images, ci/prow/okd-scos-images DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@AnnaZivkovic: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
5 participants
It has been at leas two years since the licence field has become obsolete due RHCOS GCP images already having nested virt licences by default. The licenses field is being kept for backwards compatibility
For a more detailed history reference #4696