Skip to content

OCPBUGS-19320: [release-4.13] for vsphere ipi add cluster domain to the uploaded vm configs so that…#7498

Merged
openshift-ci[bot] merged 1 commit into
openshift:release-4.13from
vrutkovs:4.13-cherry-pick-7477
Oct 9, 2023
Merged

OCPBUGS-19320: [release-4.13] for vsphere ipi add cluster domain to the uploaded vm configs so that…#7498
openshift-ci[bot] merged 1 commit into
openshift:release-4.13from
vrutkovs:4.13-cherry-pick-7477

Conversation

@vrutkovs
Copy link
Copy Markdown
Contributor

@vrutkovs vrutkovs commented Sep 18, 2023

This is an automated cherry-pick of #7477

/assign vrutkovs

@fortinj66
for vsphere ipi add cluster domain to the uploaded vm configs so that…
87d29af 
… 30-local-dns-prepender can use it

Due to changes in FCOS 35 /etc/nsswitch.conf, we need to move the name resolution of api-int.<domain> to
systemd-resolved.  The way we do this is by adding a Domain attribute to /etc/systemd/resolved.conf.d/60-kni.conf.

Since we are using a slightly different prepender than the masters and workers the domain is not being
discovered automatically.  To address this we are adding the domain in data/data/vsphere/bootstrap/main.tf
which gets uploaded to the bootstrap instance on creation.

30-local-dns-prepender then downloads this information and adds it to /etc/systemd/resolved.conf.d/60-kni.conf

Note that we check for a non-empty domain before writing /etc/systemd/resolved.conf.d/60-kni.conf.

Fixes okd-project/okd#1182

Signed-off-by: John Fortin <fortinj66@gmail.com>
@vrutkovs
Copy link
Copy Markdown
Contributor Author

vrutkovs commented Sep 18, 2023

/jira cherrypick OCPBUGS-18719

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 18, 2023

@vrutkovs: Jira Issue OCPBUGS-18719 has been cloned as Jira Issue OCPBUGS-19320. Will retitle bug to link to clone.
/retitle OCPBUGS-19320: [release-4.13] for vsphere ipi add cluster domain to the uploaded vm configs so that…

Details

In response to this:

/jira cherrypick OCPBUGS-18719

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot changed the title [release-4.13] for vsphere ipi add cluster domain to the uploaded vm configs so that… OCPBUGS-19320: [release-4.13] for vsphere ipi add cluster domain to the uploaded vm configs so that… Sep 18, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 18, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 18, 2023

@vrutkovs: This pull request references Jira Issue OCPBUGS-19320, which is invalid:

  • expected dependent Jira Issue OCPBUGS-18719 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #7477

/assign vrutkovs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs
Copy link
Copy Markdown
Contributor Author

vrutkovs commented Sep 19, 2023

/test okd-images

@jcpowermac
Copy link
Copy Markdown
Contributor

jcpowermac commented Sep 19, 2023

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2023
@sadasu
Copy link
Copy Markdown
Contributor

sadasu commented Oct 3, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 3, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Oct 3, 2023

@sadasu: This pull request references Jira Issue OCPBUGS-19320, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-18719 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-18719 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @gpei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 3, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Oct 3, 2023

@vrutkovs: This pull request references Jira Issue OCPBUGS-19320, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-18719 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-18719 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @gpei

Details

In response to this:

This is an automated cherry-pick of #7477

/assign vrutkovs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested a review from gpei October 3, 2023 20:56
@sadasu
Copy link
Copy Markdown
Contributor

sadasu commented Oct 3, 2023

/retest

@sadasu
Copy link
Copy Markdown
Contributor

sadasu commented Oct 6, 2023

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 6, 2023
@gpei
Copy link
Copy Markdown
Contributor

gpei commented Oct 6, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 6, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Oct 6, 2023

/retest-required

Remaining retests: 0 against base HEAD e1a299e and 2 for PR HEAD 87d29af in total

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 7, 2023 •
edited
Loading

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-disruptive 87d29af link false /test e2e-aws-ovn-disruptive
ci/prow/e2e-aws-ovn-workers-rhel8 87d29af link false /test e2e-aws-ovn-workers-rhel8
ci/prow/e2e-aws-ovn-upgrade 87d29af link false /test e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sadasu
Copy link
Copy Markdown
Contributor

sadasu commented Oct 9, 2023

/retest-required

@openshift-ci openshift-ci Bot merged commit 52b192d into openshift:release-4.13 Oct 9, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Oct 9, 2023

@vrutkovs: Jira Issue OCPBUGS-19320: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-19320 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #7477

/assign vrutkovs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@gpei gpei Awaiting requested review from gpei

Assignees

@vrutkovs vrutkovs

@jcpowermac jcpowermac

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vrutkovs @openshift-ci-robot @jcpowermac @sadasu @gpei @fortinj66