Skip to content

Conversation

@wgordon17
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 7, 2018
@sallyom
Copy link
Contributor

sallyom commented Dec 7, 2018

@wgordon17 I have this PR in da works :) #806
It should merge today, provided it gets past lots of ci flakes

@wgordon17
Copy link
Contributor Author

@sallyom Awesome! It still doesn't appear to update the README.md with the correct console path, so this PR is probably still beneficial

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Dec 7, 2018

@wgordon17 do you think the installer output regarding the console url on succesfull install is not sufficient and requires more documentation in README.md ?

EDIT: Also this README.md will go stale is the route changes. So IMO #806 is more appropriate for this kind of information

@wgordon17
Copy link
Contributor Author

@abhinavdahiya It honestly probably is sufficient! Perhaps I should change my PR to remove the console URL section from the README.md then?

@wking
Copy link
Member

wking commented Dec 7, 2018

Perhaps I should change my PR to remove the console URL section from the README.md then?

Yeah, can you remove the whole Connect to the cluster section? Or replace it with something that shows the tail end of the create cluster output with the lines from #806, and then talks about using that information (so folks who are just reading along can see what the next steps after running the command would be).

@wking
Copy link
Member

wking commented Dec 9, 2018

Or replace it with something that shows the tail end of the create cluster output...

If you want to go this route, they currently look like:

level=info msg="Install complete!"
level=info msg="Run 'export KUBECONFIG=/tmp/artifacts/installer/auth/kubeconfig' to manage the cluster with 'oc', the OpenShift CLI."
level=info msg="The cluster is ready when 'oc login -u kubeadmin -p yQBMF-Ahp9Q-naycI-3H7tB' succeeds (wait a few minutes)."
level=info msg="Access the OpenShift web-console here: https://console-openshift-console.apps.ci-op-siing9c6-1d3f3.origin-ci-int-aws.dev.rhcloud.com"
level=info msg="Login to the console with user: kubeadmin, password: yQBMF-Ahp9Q-naycI-3H7tB"

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 10, 2018
@wgordon17
Copy link
Contributor Author

@wking I've updated the content

@wking
Copy link
Member

wking commented Dec 10, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wgordon17, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2018
@openshift-merge-robot openshift-merge-robot merged commit 6883330 into openshift:master Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants