-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Provide the correct console URL #832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@wgordon17 I have this PR in da works :) #806 |
|
@sallyom Awesome! It still doesn't appear to update the README.md with the correct console path, so this PR is probably still beneficial |
|
@wgordon17 do you think the installer output regarding the console url on succesfull install is not sufficient and requires more documentation in EDIT: Also this README.md will go stale is the route changes. So IMO #806 is more appropriate for this kind of information |
|
@abhinavdahiya It honestly probably is sufficient! Perhaps I should change my PR to remove the console URL section from the README.md then? |
Yeah, can you remove the whole |
If you want to go this route, they currently look like: |
|
@wking I've updated the content |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wgordon17, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.