MULTIARCH-4568: Print release image arch and default arch when the payload is multi#8515
MULTIARCH-4568: Print release image arch and default arch when the payload is multi#8515openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom jeffdyoung:MULTIARCH-4568
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@jeffdyoung: This pull request references MULTIARCH-4568 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
@jeffdyoung: This pull request references MULTIARCH-4568 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
r4f4
left a comment
r4f4
left a comment
There was a problem hiding this comment.
LGTM. Left a few nitpick comments.
| } | ||
| fmt.Printf("release architecture %s\n", releaseArch) | ||
| if strings.Contains(releaseArch, "multi") || strings.Contains(releaseArch, "unknown") { | ||
| fmt.Printf("default architecture %s\n", version.DefaultArch()) |
There was a problem hiding this comment.
@r4f4 Thought it might be a good idea to print default arch when release arch is unknown? This would give some indication of what the installer will do?
jeffdyoung
changed the title
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
|
@jeffdyoung: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest |
|
@zaneb @patrickdillon looks like we are good to go on the oc side: openshift/oc#1792 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-installer-altinfra-container-v4.17.0-202407102011.p0.g03dfc1e.assembly.stream.el9 for distgit ose-installer-altinfra. |
6 participants
In parallel with: openshift/oc#1792