Skip to content

OCPBUGS-36748: Add yq-v4 to the upi-installer image for CI#8684

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.14from
Shilpa-Gokul:yq-4.14
Jul 16, 2024
Merged

OCPBUGS-36748: Add yq-v4 to the upi-installer image for CI#8684
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.14from
Shilpa-Gokul:yq-4.14

Conversation

@Shilpa-Gokul
Copy link
Copy Markdown

While new steps are being implemented in Prow, users may want to pivot to yq-v4. This commit installs yq-v4 in the upi-installer image.
Moreover, by copying the yq-v3 and yq-v4 binaries from previous stages based on manifest-list images, we guarantee the yq binaries are the ones for the architecture of the upi image being built.

…ous stage's manifest-list image

While new steps are being implemented in Prow, users may want to pivot to yq-v4. This commit installs yq-v4 in the upi-installer image.
Moreover, by copying the yq-v3 and yq-v4 binaries from previous stages based on manifest-list images, we guarantee the yq binaries are the ones for the architecture of the upi image being built.
@Shilpa-Gokul Shilpa-Gokul changed the title Add yq-v4 to the upi-installer image for CI and copy yq3 from a previ… OCPBUGS-36363: Add yq-v4 to the upi-installer image for CI and copy yq3 from a previ… Jul 1, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 1, 2024
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@Shilpa-Gokul: This pull request references Jira Issue OCPBUGS-36363, which is invalid:

  • expected the bug to target the "4.14.z" version, but no target version was set
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected Jira Issue OCPBUGS-36363 to depend on a bug targeting a version in 4.15.0, 4.15.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

While new steps are being implemented in Prow, users may want to pivot to yq-v4. This commit installs yq-v4 in the upi-installer image.
Moreover, by copying the yq-v3 and yq-v4 binaries from previous stages based on manifest-list images, we guarantee the yq binaries are the ones for the architecture of the upi image being built.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jul 1, 2024
@openshift-ci openshift-ci Bot requested review from AnnaZivkovic and rwsu July 1, 2024 06:21
@Shilpa-Gokul
Copy link
Copy Markdown
Author

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@Shilpa-Gokul: This pull request references Jira Issue OCPBUGS-36363, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected Jira Issue OCPBUGS-36363 to depend on a bug targeting a version in 4.15.0, 4.15.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Shilpa-Gokul
Copy link
Copy Markdown
Author

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@Shilpa-Gokul: This pull request references Jira Issue OCPBUGS-36363, which is invalid:

  • expected Jira Issue OCPBUGS-36363 to depend on a bug targeting a version in 4.15.0, 4.15.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Shilpa-Gokul
Copy link
Copy Markdown
Author

/jira refresh

1 similar comment
@Shilpa-Gokul
Copy link
Copy Markdown
Author

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@Shilpa-Gokul: This pull request references Jira Issue OCPBUGS-36363, which is invalid:

  • expected Jira Issue OCPBUGS-36363 to depend on a bug targeting a version in 4.15.0, 4.15.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Shilpa-Gokul
Copy link
Copy Markdown
Author

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jul 1, 2024

@Shilpa-Gokul: This pull request references Jira Issue OCPBUGS-36363, which is invalid:

  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • bug has dependents
  • dependent bug MIXEDARCH-353 is not in the required OCPBUGS project

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Copy Markdown
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2024
@Shilpa-Gokul
Copy link
Copy Markdown
Author

/retest-required

@Shilpa-Gokul
Copy link
Copy Markdown
Author

/test e2e-gcp-ovn-upi

@Shilpa-Gokul
Copy link
Copy Markdown
Author

/retest-required

@Shilpa-Gokul
Copy link
Copy Markdown
Author

/retest-required

@r4f4
Copy link
Copy Markdown
Contributor

r4f4 commented Jul 9, 2024

/retitle OCPBUGS-36748: Add yq-v4 to the upi-installer image for CI

@openshift-ci openshift-ci Bot changed the title OCPBUGS-36363: Add yq-v4 to the upi-installer image for CI and copy yq3 from a previ… OCPBUGS-36748: Add yq-v4 to the upi-installer image for CI Jul 9, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 9, 2024
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@Shilpa-Gokul: This pull request references Jira Issue OCPBUGS-36748, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-36747 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-36747 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
  • bug has dependents

Requesting review from QA contact:
/cc @juliemathew

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

While new steps are being implemented in Prow, users may want to pivot to yq-v4. This commit installs yq-v4 in the upi-installer image.
Moreover, by copying the yq-v3 and yq-v4 binaries from previous stages based on manifest-list images, we guarantee the yq binaries are the ones for the architecture of the upi image being built.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested a review from juliemathew July 9, 2024 11:24
@r4f4
Copy link
Copy Markdown
Contributor

r4f4 commented Jul 9, 2024

/assign @sadasu
for the backport label.

@Shilpa-Gokul
Copy link
Copy Markdown
Author

/test e2e-azure-ovn-upi

@Shilpa-Gokul
Copy link
Copy Markdown
Author

@r4f4
e2e-gcp-ovn-upi and e2e-azure-ovn-upi is already failing in periodic jobs with same error, so this PR has no impact on it, can you please override this failure?

@Shilpa-Gokul
Copy link
Copy Markdown
Author

/test e2e-azure-ovn-upi

@r4f4
Copy link
Copy Markdown
Contributor

r4f4 commented Jul 15, 2024

/override ci/prow/e2e-gcp-ovn-upi

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 15, 2024

@r4f4: Overrode contexts on behalf of r4f4: ci/prow/e2e-gcp-ovn-upi

Details

In response to this:

/override ci/prow/e2e-gcp-ovn-upi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@r4f4
Copy link
Copy Markdown
Contributor

r4f4 commented Jul 15, 2024

/override ci/prow/e2e-azure-ovn-upi
e2e failures not related to PR changes.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 15, 2024

@r4f4: Overrode contexts on behalf of r4f4: ci/prow/e2e-azure-ovn-upi

Details

In response to this:

/override ci/prow/e2e-azure-ovn-upi
e2e failures not related to PR changes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 15, 2024

@Shilpa-Gokul: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn f575b81 link false /test okd-scos-e2e-aws-ovn
ci/prow/okd-scos-e2e-gcp f575b81 link false /test okd-scos-e2e-gcp
ci/prow/okd-scos-e2e-gcp-ovn-upgrade f575b81 link false /test okd-scos-e2e-gcp-ovn-upgrade
ci/prow/okd-scos-e2e-aws-upgrade f575b81 link false /test okd-scos-e2e-aws-upgrade
ci/prow/okd-e2e-aws-ovn-upgrade f575b81 link false /test okd-e2e-aws-ovn-upgrade
ci/prow/okd-e2e-aws-ovn f575b81 link false /test okd-e2e-aws-ovn
ci/prow/okd-scos-e2e-vsphere f575b81 link false /test okd-scos-e2e-vsphere
ci/prow/e2e-azure-ovn-upi f575b81 link true /test e2e-azure-ovn-upi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@r4f4
Copy link
Copy Markdown
Contributor

r4f4 commented Jul 16, 2024

/assign @gpei
for the cherry-pick label

@gpei
Copy link
Copy Markdown
Contributor

gpei commented Jul 16, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 16, 2024
Copy link
Copy Markdown
Contributor

@barbacbd barbacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2024
@sadasu
Copy link
Copy Markdown
Contributor

sadasu commented Jul 16, 2024

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jul 16, 2024
@openshift-merge-bot openshift-merge-bot Bot merged commit 1cae2a0 into openshift:release-4.14 Jul 16, 2024
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@Shilpa-Gokul: Jira Issue OCPBUGS-36748: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36748 has been moved to the MODIFIED state.

Details

In response to this:

While new steps are being implemented in Prow, users may want to pivot to yq-v4. This commit installs yq-v4 in the upi-installer image.
Moreover, by copying the yq-v3 and yq-v4 binaries from previous stages based on manifest-list images, we guarantee the yq binaries are the ones for the architecture of the upi image being built.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Copy Markdown
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-baremetal-installer-container-v4.14.0-202407161539.p0.g1cae2a0.assembly.stream.el8 for distgit ose-baremetal-installer.
All builds following this will include this PR.

@openshift-bot
Copy link
Copy Markdown
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-container-v4.14.0-202407161539.p0.g1cae2a0.assembly.stream.el8 for distgit ose-installer.
All builds following this will include this PR.

@Shilpa-Gokul
Copy link
Copy Markdown
Author

/cherry-pick release-4.13

@openshift-cherrypick-robot
Copy link
Copy Markdown

@Shilpa-Gokul: new pull request created: #8743

Details

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot
Copy link
Copy Markdown
Contributor

Fix included in accepted release 4.14.0-0.nightly-2024-07-18-144042

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants