[release-4.16] OCPBUGS-43967: Revendor assisted service external platform oci

[pawanpinjarkar]

Manual cherry-pick of #9147

[openshift-ci-robot]

@pawanpinjarkar: This pull request references Jira Issue OCPBUGS-43967, which is invalid:

• expected Jira Issue OCPBUGS-43967 to depend on a bug targeting a version in 4.17.0, 4.17.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Manual cherry-pick of #9147

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[pawanpinjarkar]

/jira refresh

[openshift-ci-robot]

@pawanpinjarkar: This pull request references Jira Issue OCPBUGS-43967, which is invalid:

• expected dependent Jira Issue OCPBUGS-43897 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[pawanpinjarkar]

/retest-required

[bfournie]

I'm wondering why verify-vendor is failing. It doesn't look like a sporadic issue.

[pawanpinjarkar]

/retest-required

[openshift-ci]

@pawanpinjarkar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-vsphere-ovn	51a68e0	link	false	/test okd-scos-e2e-vsphere-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[bfournie]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [bfournie]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pawanpinjarkar]

/jira refresh

[openshift-ci-robot]

@pawanpinjarkar: This pull request references Jira Issue OCPBUGS-43967, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.z) matches configured target version for branch (4.16.z)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-43897 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-43897 targets the "4.17.z" version, which is one of the valid target versions: 4.17.0, 4.17.z
• bug has dependents

Requesting review from QA contact:
/cc @mhanss

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[zaneb]

This is revendoring to the same commit as the 4.17 PR, which is presumably in the 4.17 (or worse, 4.18) branch. That seems risky to me as it will pick up far more commits than we are intending, with unknown consequences.
What is that patch that we actually need? It would be safer to backport that patch to the 4.16 branch of assisted-installer and then rebase to that.

[pawanpinjarkar]

This is revendoring to the same commit as the 4.17 PR, which is presumably in the 4.17 (or worse, 4.18) branch. That seems risky to me as it will pick up far more commits than we are intending, with unknown consequences. What is that patch that we actually need? It would be safer to backport that patch to the 4.16 branch of assisted-installer and then rebase to that.

in 4.17 PR, we only revendored this specific commit openshift/assisted-service@d41f536

If it is safer to not cherrypick from 4.17 but do a seperate revendoring of assisted-service in 4.16 (this specific commit openshift/assisted-service@d41f536 ), I can close this PR and open a new one.

[zaneb]

The specific point we are revendoring to (openshift/assisted-service@6573b5d7021d) is already part of the release-4.16 branch, so we are not pulling in any changes to assisted-service that post-date this release. A manual review of the diff shows nothing too alarming.
/label backport-risk-assessed

[mhanss]

/label cherry-pick-approved

[rwsu]

/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD edf5606 and 2 for PR HEAD 51a68e0 in total

[openshift-ci-robot]

@pawanpinjarkar: Jira Issue OCPBUGS-43967: All pull requests linked via external trackers have merged:

• openshift/installer#9150

Jira Issue OCPBUGS-43967 has been moved to the MODIFIED state.

Details

In response to this:

Manual cherry-pick of #9147

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer
This PR has been included in build ose-baremetal-installer-container-v4.16.0-202411080236.p0.gf12bc39.assembly.stream.el9.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-altinfra
This PR has been included in build ose-installer-altinfra-container-v4.16.0-202411080236.p0.gf12bc39.assembly.stream.el9.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-terraform-providers
This PR has been included in build ose-installer-terraform-providers-container-v4.16.0-202411080236.p0.gf12bc39.assembly.stream.el9.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts
This PR has been included in build ose-installer-artifacts-container-v4.16.0-202411080236.p0.gf12bc39.assembly.stream.el9.
All builds following this will include this PR.