Skip to content

TRT-1949: gather: allow unconditional gather in CI#9355

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
stbenjam:bootstrap-gather
Jan 15, 2025
Merged

TRT-1949: gather: allow unconditional gather in CI#9355
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
stbenjam:bootstrap-gather

Conversation

@stbenjam
Copy link
Copy Markdown
Member

@stbenjam stbenjam commented Jan 10, 2025 •
edited
Loading

In CI, we want to collect an installer log bundle so we can examine bootstrap logs that aren't retrievable from anywhere else. This is especially important for problems that might happen during early install.

Release PR: openshift/release#60534

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 10, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 10, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@stbenjam
Copy link
Copy Markdown
Member Author

stbenjam commented Jan 10, 2025

/test e2e-aws-ovn

@patrickdillon
Copy link
Copy Markdown
Contributor

patrickdillon commented Jan 10, 2025

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2025
@stbenjam
gather: allow unconditional gather in CI
89e4838 
In CI, we want to collect an installer log bundle so we can examine
bootstrap logs that aren't retrievable from anywhere else. This is
especially important for problems that might happen during early
install.
@stbenjam
Copy link
Copy Markdown
Member Author

stbenjam commented Jan 10, 2025

Successful: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_installer/9355/pull-ci-openshift-installer-main-e2e-aws-ovn/1877750750768009216/artifacts/e2e-aws-ovn/ipi-install-install/artifacts/

@stbenjam stbenjam marked this pull request as ready for review January 10, 2025 19:39
@stbenjam stbenjam changed the title [WIP] gather: allow unconditional gather in CI gather: allow unconditional gather in CI Jan 10, 2025
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 10, 2025
@openshift-ci openshift-ci Bot requested review from r4f4 and rwsu January 10, 2025 19:40
patrickdillon
patrickdillon reviewed Jan 10, 2025
View reviewed changes
Comment thread cmd/openshift-install/create.go Outdated
@stbenjam @patrickdillon
Update cmd/openshift-install/create.go
a733f78 
Co-authored-by: Patrick Dillon <pdd@redhat.com>
@r4f4
Copy link
Copy Markdown
Contributor

r4f4 commented Jan 13, 2025

/uncc
/cc @barbacbd

@openshift-ci openshift-ci Bot requested review from barbacbd and removed request for r4f4 January 13, 2025 12:25
@patrickdillon
Copy link
Copy Markdown
Contributor

patrickdillon commented Jan 13, 2025

/label tide/merge-method-squash

@openshift-ci openshift-ci Bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 13, 2025
@patrickdillon patrickdillon changed the title gather: allow unconditional gather in CI no-jira: gather: allow unconditional gather in CI Jan 13, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 13, 2025
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jan 13, 2025

@stbenjam: This pull request explicitly references no jira issue.

Details

In response to this:

In CI, we want to collect an installer log bundle so we can examine bootstrap logs that aren't retrievable from anywhere else. This is especially important for problems that might happen during early install.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

barbacbd
barbacbd reviewed Jan 13, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@barbacbd barbacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Can we link this to a release PR since there is no Jira issue?

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2025
@deads2k deads2k added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jan 13, 2025
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jan 13, 2025

/retest-required

Remaining retests: 0 against base HEAD 358ca0f and 2 for PR HEAD a733f78 in total

@stbenjam stbenjam mentioned this pull request Jan 13, 2025
Merged
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jan 13, 2025

@stbenjam: This pull request explicitly references no jira issue.

Details

In response to this:

In CI, we want to collect an installer log bundle so we can examine bootstrap logs that aren't retrievable from anywhere else. This is especially important for problems that might happen during early install.

Release PR: openshift/release#60534

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jan 14, 2025

/retest-required

Remaining retests: 0 against base HEAD 358ca0f and 2 for PR HEAD a733f78 in total

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 14, 2025 •
edited
Loading

@stbenjam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-multi-network a733f78 link false /test e2e-vsphere-ovn-multi-network
ci/prow/e2e-azure-ovn-resourcegroup a733f78 link false /test e2e-azure-ovn-resourcegroup
ci/prow/e2e-vsphere-static-ovn a733f78 link false /test e2e-vsphere-static-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jan 15, 2025

/retest-required

Remaining retests: 0 against base HEAD 7a23573 and 1 for PR HEAD a733f78 in total

@openshift-merge-bot openshift-merge-bot Bot merged commit 2fed4ed into openshift:main Jan 15, 2025
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 15, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-altinfra
This PR has been included in build ose-installer-altinfra-container-v4.19.0-202501150711.p0.g2fed4ed.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 15, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-terraform-providers
This PR has been included in build ose-installer-terraform-providers-container-v4.19.0-202501150711.p0.g2fed4ed.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 15, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer
This PR has been included in build ose-baremetal-installer-container-v4.19.0-202501151140.p0.g2fed4ed.assembly.stream.el9.
All builds following this will include this PR.

@stbenjam stbenjam changed the title no-jira: gather: allow unconditional gather in CI TRT-1949: gather: allow unconditional gather in CI Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrickdillon patrickdillon patrickdillon left review comments

@rwsu rwsu Awaiting requested review from rwsu

+1 more reviewer

@barbacbd barbacbd barbacbd left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@barbacbd barbacbd

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@stbenjam @patrickdillon @r4f4 @openshift-ci-robot @openshift-bot @barbacbd @deads2k