Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Dec 18, 2018

Catching up with 6be4c25 (#861).

Also link to the troubleshooting docs, since the easier it is to discover those, the fewer bug reports we'll get with insufficient detail ;).

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 18, 2018
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2018
Catching up with 6be4c25 (*: remove support for environment
variables, 2018-12-10, openshift#861).

Also link to the troubleshooting docs, since the easier it is to
discover those, the fewer bug reports we'll get with insufficient
detail ;).
@wking wking force-pushed the stale-readme-environment-variable-reference branch from 9ef653f to c1a7ca1 Compare December 18, 2018 07:19
Copy link
Contributor

@crawford crawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit dd6fd9f into openshift:master Dec 18, 2018
@wking wking deleted the stale-readme-environment-variable-reference branch December 18, 2018 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants