hack/build: Pin to RHCOS 47.235 and quay.io/openshift-release-dev/ocp-release:4.0.0-8 #972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Through c0104bd (Merge pull request openshift#970 from openshift/revert-927-aws-public-worker-ips, 2018-12-21).
…-release:4.0.0-8 That's the latest RHCOS release: $ curl -s https://releases-rhcos.svc.ci.openshift.org/storage/releases/maipo/builds.json | jq '{latest: .builds[0], timestamp}' { "latest": "47.235", "timestamp": "2018-12-23T05:40:56Z" } And Clayton just pushed a recent update payload to quay.io/openshift-release-dev/ocp-release:4.0.0-8. Renaming OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE gets us CI testing of the pinned release despite openshift/release@60007df2 (Use RELEASE_IMAGE_LATEST for CVO payload, 2018-10-03, openshift/release#1793). I'd initially expected to export the pinning environment variables in release.sh, but I've put them in build.sh here because our continuous integration tests use build.sh directly and don't go through release.sh.
openshift-ci-robot
added
the
size/M
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
crawford
reviewed
Dec 23, 2018
Contributor
crawford
left a comment
crawford
left a comment
There was a problem hiding this comment.
Looks good. Tests passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE!
That's the latest RHCOS release:
And @smarterclayton just pushed a recent update payload to quay.io/openshift-release-dev/ocp-release:4.0.0-8.
Renaming
OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDEgets us CI testing of the pinned release despite openshift/release@60007df2 (openshift/release#1793).I'd initially expected to export the pinning environment variables in
release.sh, but I've put them inbuild.shhere because our continuous integration tests usebuild.shdirectly and don't go throughrelease.sh.