MAINTAINERS: Drop stale file #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MAINTAINERS is obsolete since 49779c3 (OWNERS: Configure Prow with approver and reviewer information, 2018-07-25, openshift#71). I've also dropped the email/IRC section, since as far as I know there are currently no public lists or IRC channels for installer discussion. Folks outside of Red Hat should communicate via GitHub issues and pull requests, and I think that's the expectation for projects that don't give alternatives in their CONTRIBUTING file.
This was for coreos/tectonic-installer. New features are welcome for openshift/installer.
openshift-ci-robot
added
the
size/S
Contributor
|
/assign @yifan-gu |
Contributor
|
lgtm but will let others approve |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wking, yifan-gu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
stbenjam
pushed a commit
to stbenjam/installer
that referenced
this pull request
Feb 10, 2021
bug 1906143: Use k8s.io/klog instead of zap
clnperez
pushed a commit
to clnperez/installer
that referenced
this pull request
Jan 31, 2022
…ift#98) Signed-off-by: Hiro Miyamoto <miyamotoh@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAINTAINERS is obsolete since 49779c3 (#71). I've also dropped the email/IRC section, since as far as I know there are currently no public lists or IRC channels for installer discussion. Folks outside of Red Hat should communicate via GitHub issues and pull requests, and I think that's the expectation for projects that don't give alternatives in their
CONTRIBUTINGfile.I've also dropped the feature-freeze comment from the
ISSUE_TEMPLATE. It was for coreos/tectonic-installer, but new features are welcome for openshift/installer./assign @smarterclayton