OPNET-678: Allow disabling internal DNS by cybertron · Pull Request #9924 · openshift/installer

cybertron · 2025-09-03T15:47:46Z

No description provided.

openshift-ci · 2025-09-03T15:47:51Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

cybertron · 2025-11-17T22:47:40Z

This includes #10097 but I split the api bump out because I think it should be easier to review in isolation.

openshift-ci-robot · 2025-11-17T22:48:05Z

@cybertron: This pull request references OPNET-678 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tthvo · 2025-11-18T01:22:43Z

/retest

tthvo

Nice 👍 🚀

I have a couple small questions only :D

Also, I think we need to drop the changes for openshift/api vendor since it's already on main? Maybe, a quick rebase on top of main will naturally solve it...

tthvo · 2025-11-18T22:58:22Z

+		{
+			FeatureGateName: features.FeatureGateOnPremDNSRecords,
+			Condition:       v.DNSRecordsType == configv1.DNSRecordsTypeExternal,
+			Field:           field.NewPath("platform", "vsphere", "DNSRecordsType"),


Suggested change

Field: field.NewPath("platform", "vsphere", "DNSRecordsType"),

Field: field.NewPath("platform", "vsphere", "dnsRecordsType"),

nit: we should use the serialized name of the field for field path, right? Same questions for openstack, baremetal, and nutanix too 💭

Yeah, looks like that's consistent with the existing checks. I'll change it.

tthvo · 2025-11-18T23:10:31Z

 			APIServerInternalIPs: installConfig.Config.Platform.BareMetal.APIVIPs,
 			IngressIPs:           installConfig.Config.Platform.BareMetal.IngressVIPs,
 			LoadBalancer:         installConfig.Config.Platform.BareMetal.LoadBalancer,
+			DNSRecordsType:       installConfig.Config.Platform.BareMetal.DNSRecordsType,


💡 Do we need to set this field in the infrastructure status for platform vsphere, openstack, and nutanix too?

Oops, yes. Fixed.

Wire in the internalDNSRecords API field to install-config so we can disable the internal DNS records for deployments using a user-managed loadbalancer. Co-Authored-By: Claude <noreply@anthropic.com>

Also makes the featuregate validations consistent with the existing checks.

cybertron · 2025-11-19T18:02:44Z

Also fixed the integration test failure.

tthvo · 2025-11-19T19:09:37Z

/test verify-vendor

tthvo

/lgtm

mkowalski · 2025-11-21T16:31:29Z

/lgtm

tthvo · 2025-11-24T05:57:49Z

/hold cancel
/retest

openshift-ci-robot · 2025-11-24T11:09:33Z

/retest-required

Remaining retests: 0 against base HEAD 90b08c7 and 2 for PR HEAD 534ea54 in total

cybertron · 2025-11-24T14:45:23Z

/retest-required

The openstack job seems kind of unstable lately, but it did pass on an earlier version of this patch so I don't think it's a legitimate failure.

cybertron · 2025-11-24T18:53:08Z

/retest-required

openshift-ci-robot · 2025-11-25T01:09:22Z

/retest-required

Remaining retests: 0 against base HEAD 54f4b77 and 1 for PR HEAD 534ea54 in total

cybertron · 2025-11-25T20:36:06Z

/retest-required

The openstack job failed on different tests this time. Progress, I guess?

mkowalski · 2025-11-26T10:26:41Z

/test e2e-openstack-ovn

openshift-ci-robot · 2025-11-26T13:15:11Z

/retest-required

Remaining retests: 0 against base HEAD b4fa331 and 0 for PR HEAD 534ea54 in total

openshift-ci-robot · 2025-11-26T15:14:59Z

/hold

Revision 534ea54 was retested 3 times: holding

tthvo · 2025-11-26T16:43:23Z

/test e2e-openstack-ovn

again?

tthvo · 2025-11-26T19:26:37Z

Hmm, looks like the install couldn't complete... I am not sure what's going on here 😞

cybertron · 2025-11-26T21:25:37Z

I've reached out to the openstack team to see if they have any ideas. This has passed multiple other on-prem jobs and I can see from some of the job logs that coredns was working correctly in the clusters, so I don't think this patch is causing the failure.

tthvo · 2025-11-26T21:38:54Z

Thanks Ben, I'll leave it to you to remove the hold then :D Hopefully, it is resolved 🤞

mkowalski · 2025-11-27T09:01:37Z

/hold cancel

Whenever openstack is done with their fix

openshift-ci-robot · 2025-11-27T09:25:35Z

/retest-required

Remaining retests: 0 against base HEAD b4fa331 and 2 for PR HEAD 534ea54 in total

openshift-ci-robot · 2025-11-28T14:38:51Z

/retest-required

Remaining retests: 0 against base HEAD 7d0584e and 1 for PR HEAD 534ea54 in total

openshift-ci-robot · 2025-12-01T21:38:45Z

/retest-required

Remaining retests: 0 against base HEAD fd5a518 and 0 for PR HEAD 534ea54 in total

openshift-ci · 2025-12-02T00:01:43Z

@cybertron: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-fips	`dc21cb3`	link	false	`/test e2e-aws-ovn-fips`
ci/prow/e2e-aws-ovn-single-node	`dc21cb3`	link	false	`/test e2e-aws-ovn-single-node`
ci/prow/e2e-aws-ovn-heterogeneous	`dc21cb3`	link	false	`/test e2e-aws-ovn-heterogeneous`
ci/prow/e2e-aws-ovn-imdsv2	`dc21cb3`	link	false	`/test e2e-aws-ovn-imdsv2`
ci/prow/e2e-metal-assisted	`534ea54`	link	false	`/test e2e-metal-assisted`
ci/prow/e2e-nutanix-ovn	`534ea54`	link	false	`/test e2e-nutanix-ovn`
ci/prow/e2e-openstack-proxy	`534ea54`	link	false	`/test e2e-openstack-proxy`
ci/prow/e2e-agent-two-node-fencing-ipv4	`534ea54`	link	false	`/test e2e-agent-two-node-fencing-ipv4`
ci/prow/okd-scos-e2e-vsphere-ovn	`534ea54`	link	false	`/test okd-scos-e2e-vsphere-ovn`
ci/prow/e2e-metal-ovn-two-node-fencing	`534ea54`	link	false	`/test e2e-metal-ovn-two-node-fencing`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2025-12-02T00:38:41Z

/hold

Revision 534ea54 was retested 3 times: holding

patrickdillon · 2025-12-02T18:53:18Z

/hold cancel
/skip

patrickdillon · 2025-12-02T18:54:31Z

/override ci/prow/e2e-openstack-ovn

openshift-ci · 2025-12-02T18:55:55Z

@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/e2e-openstack-ovn

Details

In response to this:

/override ci/prow/e2e-openstack-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2025-12-02T22:15:43Z

/retest-required

Remaining retests: 0 against base HEAD 75bbd5d and 2 for PR HEAD 534ea54 in total

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 3, 2025

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 3, 2025

cybertron mentioned this pull request Sep 3, 2025

OPNET-678: Make VIPs optional with external loadbalancer openshift/enhancements#1803

Closed

cybertron force-pushed the disable-internal-dns branch from 322d1f0 to ec64c52 Compare November 17, 2025 22:45

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2025

cybertron changed the title ~~Allow disabling internal DNS~~ OPNET-678: Allow disabling internal DNS Nov 17, 2025

cybertron marked this pull request as ready for review November 17, 2025 22:48

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 17, 2025

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 17, 2025

openshift-ci Bot requested review from andfasano and honza November 17, 2025 22:49

cybertron force-pushed the disable-internal-dns branch 3 times, most recently from 9d31157 to dc21cb3 Compare November 18, 2025 22:33

tthvo reviewed Nov 18, 2025

View reviewed changes

cybertron and others added 3 commits November 19, 2025 11:10

OPNET-678: Allow disabling internal DNS

8f91fb5

Wire in the internalDNSRecords API field to install-config so we can disable the internal DNS records for deployments using a user-managed loadbalancer. Co-Authored-By: Claude <noreply@anthropic.com>

Populate platformStatus for all on-prem platforms

307d0b0

Also makes the featuregate validations consistent with the existing checks.

Fix nutanix integration test for dnsRecordsType

534ea54

cybertron force-pushed the disable-internal-dns branch from dc21cb3 to 534ea54 Compare November 19, 2025 18:01

tthvo reviewed Nov 19, 2025

View reviewed changes

openshift-ci Bot assigned tthvo Nov 19, 2025

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2025

mkowalski approved these changes Nov 21, 2025

View reviewed changes

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2025

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 24, 2025

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 26, 2025

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 27, 2025

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2025

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2025

openshift-merge-bot Bot merged commit 3b6ba6b into openshift:main Dec 3, 2025
48 checks passed

	Field: field.NewPath("platform", "vsphere", "DNSRecordsType"),
	Field: field.NewPath("platform", "vsphere", "dnsRecordsType"),

Conversation

cybertron commented Sep 3, 2025

Uh oh!

openshift-ci Bot commented Sep 3, 2025

Uh oh!

cybertron commented Nov 17, 2025

Uh oh!

openshift-ci-robot commented Nov 17, 2025 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tthvo commented Nov 18, 2025

Uh oh!

tthvo left a comment

Choose a reason for hiding this comment

Uh oh!

tthvo Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

cybertron Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

tthvo Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

cybertron Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

cybertron commented Nov 19, 2025

Uh oh!

tthvo commented Nov 19, 2025

Uh oh!

tthvo left a comment

Choose a reason for hiding this comment

Uh oh!

mkowalski commented Nov 21, 2025

Uh oh!

tthvo commented Nov 24, 2025

Uh oh!

openshift-ci-robot commented Nov 24, 2025

Uh oh!

cybertron commented Nov 24, 2025

Uh oh!

cybertron commented Nov 24, 2025

Uh oh!

openshift-ci-robot commented Nov 25, 2025

Uh oh!

cybertron commented Nov 25, 2025

Uh oh!

mkowalski commented Nov 26, 2025

Uh oh!

openshift-ci-robot commented Nov 26, 2025

Uh oh!

openshift-ci-robot commented Nov 26, 2025

Uh oh!

tthvo commented Nov 26, 2025

Uh oh!

tthvo commented Nov 26, 2025

Uh oh!

cybertron commented Nov 26, 2025

Uh oh!

tthvo commented Nov 26, 2025

Uh oh!

mkowalski commented Nov 27, 2025

Uh oh!

openshift-ci-robot commented Nov 27, 2025

Uh oh!

openshift-ci-robot commented Nov 28, 2025

Uh oh!

openshift-ci-robot commented Dec 1, 2025

Uh oh!

openshift-ci Bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Dec 2, 2025

Uh oh!

patrickdillon commented Dec 2, 2025

Uh oh!

patrickdillon commented Dec 2, 2025

Uh oh!

openshift-ci Bot commented Dec 2, 2025

openshift-ci-robot commented Nov 17, 2025 •

edited by openshift-ci Bot

Loading

openshift-ci Bot commented Dec 2, 2025 •

edited

Loading