Skip to content

Bug 1841315: get test pipeline working after unskipping openshift build tests#330

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
gabemontero:fixup-test-pipeline
May 28, 2020
Merged

Bug 1841315: get test pipeline working after unskipping openshift build tests#330
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
gabemontero:fixup-test-pipeline

Conversation

@gabemontero
Copy link
Copy Markdown
Contributor

So we had to disable https://github.com/openshift/origin/blob/master/test/extended/builds/pipeline_origin_bld.go when https://bugzilla.redhat.com/show_bug.cgi?id=1783530 first arose

That was done via openshift/origin#24304

I noticed that https://bugzilla.redhat.com/show_bug.cgi?id=1783530 was finally marked verified earlier this month as the JDK fix we depended on eventually landed

In creating openshift/origin#25033 the client plugin test using this file was failling.

I reproduced locally, and verified these changes locally.

Once this merges, I'll update the re-enabled test (clean up some of the cleanup stuff) and finish re-enabling the test.

These changes @akram @waveywaves are of course not an exact change from the jenkins-second-deployment usage, which I'm assuming you all started to move off of becasue of memory demands, but is close enough for now IMO, and sufficient to get the test re-enablement going.

Finally, as a reminder, the pipeline_jenkins_e2e.go tests stayed unskipped during all this.

@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2020
@gabemontero gabemontero changed the title get test pipeline working after unskipping openshift build tests Bug 1841315: get test pipeline working after unskipping openshift build tests May 28, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 28, 2020
@openshift-ci-robot
Copy link
Copy Markdown

@gabemontero: This pull request references Bugzilla bug 1841315, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1841315: get test pipeline working after unskipping openshift build tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero
Copy link
Copy Markdown
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 28, 2020
@openshift-ci-robot
Copy link
Copy Markdown

@gabemontero: This pull request references Bugzilla bug 1841315, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 28, 2020
@gabemontero gabemontero added the lgtm Indicates that a PR is ready to be merged. label May 28, 2020
@openshift-merge-robot openshift-merge-robot merged commit 4f11936 into openshift:master May 28, 2020
@openshift-ci-robot
Copy link
Copy Markdown

@gabemontero: Some pull requests linked via external trackers have merged: . The following pull requests linked via external trackers have not merged:

Details

In response to this:

Bug 1841315: get test pipeline working after unskipping openshift build tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants