This repository was archived by the owner on Dec 1, 2022. It is now read-only.
Merged
Conversation
openshift-ci-robot
added
approved
navidshaikh
commented
Jul 4, 2019
| ./kn service update hello --env TARGET=kn || failed=1 | ||
| sleep 20 | ||
| ./kn revision get || failed=1 | ||
| ./kn service get || failed=1 |
Author
There was a problem hiding this comment.
@rhuss : var failed was getting overridden with following commands' success thus, it didnt report the failure since a while (we renamed get to list a while ago).
Also we'll need to get the e2e tests in shape.
navidshaikh
requested review from
rhuss
and removed request for
bbrowning and
markusthoemmes
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: navidshaikh, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces existing e2e tests with upstream smoke tests.