Skip to content
This repository was archived by the owner on Dec 1, 2022. It is now read-only.

Ignores if requested project not found#24

Merged
openshift-merge-robot merged 1 commit intomasterfrom
nshaikh-master
Jul 11, 2019
Merged

Ignores if requested project not found#24
openshift-merge-robot merged 1 commit intomasterfrom
nshaikh-master

Conversation

@navidshaikh
Copy link
Copy Markdown

adds --ignore-not-found=true while deleting knative-serving namespace

/assign @rhuss

 adds --ignore-not-found=true while deleting knative-serving namespace

 /assign @rhuss
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 9, 2019
@navidshaikh
Copy link
Copy Markdown
Author

/assign @rhuss

Copy link
Copy Markdown

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@rhuss
Copy link
Copy Markdown

rhuss commented Jul 11, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2019
@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 8de8c30 into master Jul 11, 2019
@navidshaikh navidshaikh deleted the nshaikh-master branch July 16, 2019 11:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants