Skip to content
This repository was archived by the owner on Dec 1, 2022. It is now read-only.

🤖 Triggering CI on branch 'release-next' after synching to upstream/master#4

Merged
openshift-merge-robot merged 1 commit intorelease-nextfrom
release-next-ci
Jun 21, 2019
Merged

🤖 Triggering CI on branch 'release-next' after synching to upstream/master#4
openshift-merge-robot merged 1 commit intorelease-nextfrom
release-next-ci

Conversation

@alanfx
Copy link
Copy Markdown

@alanfx alanfx commented Jun 19, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 19, 2019
@navidshaikh
Copy link
Copy Markdown

navidshaikh commented Jun 19, 2019

/retest

@rhuss
Copy link
Copy Markdown

rhuss commented Jun 19, 2019

@navidshaikh I guess the PR needs to be rebased on master first (as this is still the release-next-ci branch)

I suggest just to merge and wait for tomorrow nights PR ?

@navidshaikh
Copy link
Copy Markdown

navidshaikh commented Jun 19, 2019

@rhuss :

I guess the PR needs to be rebased on master first (as this is still the release-next-ci branch)

Yup.

I suggest just to merge and wait for tomorrow nights PR ?

We can run https://github.com/openshift/knative-client/blob/master/openshift/release/update-to-head.sh to update release-next and release-next-ci branches to update same PR, I just ran same above.

@navidshaikh
Copy link
Copy Markdown

navidshaikh commented Jun 19, 2019

Failure of tests complains

🔥 No license header found in:
   ./openshift/olm/knative-serving.catalogsource.yaml

@alanfx alanfx force-pushed the release-next-ci branch from ceb9e33 to a156b1c Compare June 19, 2019 11:59
@alanfx alanfx force-pushed the release-next-ci branch from a156b1c to d59bdd5 Compare June 20, 2019 00:43
@alanfx alanfx force-pushed the release-next-ci branch from d59bdd5 to ae6abb4 Compare June 20, 2019 21:43
@alanfx alanfx force-pushed the release-next-ci branch from ae6abb4 to e8bd502 Compare June 21, 2019 00:45
@navidshaikh
Copy link
Copy Markdown

navidshaikh commented Jun 21, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2019
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 21, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanfx, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit c9ef507 into release-next Jun 21, 2019
@alanfx
Copy link
Copy Markdown
Author

alanfx commented Jun 21, 2019

Hm, not sure why the webhook didn't merge this PR. I'll take a look

alanfx pushed a commit that referenced this pull request Mar 10, 2021
@eletonia
kn source-list types: adding column to specify built-in source (knati…
a9687c6 
…ve#1246)

* # This is a combination of 9 commits.
# This is the 1st commit message:
adding BUILT-IN SOURCE column for kn source list-types

# The commit message #2 will be skipped:

#	changing list test to check for BUILT-IN SOURCE column

# The commit message #3 will be skipped:

#	changing e2e source list test to check for BUILT-IN SOURCE column

# The commit message #4 will be skipped:

#	adding CHANGELOG entry

# The commit message #5 will be skipped:

#	kn source list-types: changing BUILT-IN SOURCE to BUILT-IN and moving DESCRIPTION column to the end

# The commit message #6 will be skipped:

#	changing BUILT-IN SOURCE to BUILT-IN in changelog

# The commit message #7 will be skipped:

#	Update CHANGELOG.adoc
#
#	Co-authored-by: David Simansky <dsimansk@redhat.com>

# The commit message #8 will be skipped:

#	kn source list-types: changing column header to S, values to X, and moving to second column

# The commit message #9 will be skipped:

#	fixing CHANGELOG merge conflict

* adding BUILT-IN SOURCE column for kn source list-types
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bbrowning bbrowning Awaiting requested review from bbrowning

@rhuss rhuss Awaiting requested review from rhuss

Assignees

@navidshaikh navidshaikh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/sync-fork-to-upstream lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alanfx @navidshaikh @rhuss @openshift-ci-robot @openshift-merge-robot