Skip to content
This repository was archived by the owner on Dec 1, 2022. It is now read-only.

Package and serve binaries for all RHEL architectures#413

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
multi-arch:master
Jan 14, 2021
Merged

Package and serve binaries for all RHEL architectures#413
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
multi-arch:master

Conversation

@yselkowitz
Copy link
Copy Markdown

Filing relevant parts to master based on feedback in #411

@openshift-ci-robot
Copy link
Copy Markdown

Hi @yselkowitz. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 1, 2020
@yselkowitz
Copy link
Copy Markdown
Author

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 10, 2020
@openshift-bot
Copy link
Copy Markdown

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 27, 2020
@yselkowitz
Copy link
Copy Markdown
Author

/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 27, 2020
@yselkowitz
Copy link
Copy Markdown
Author

/cherry-pick release-v0.19.1

@openshift-cherrypick-robot
Copy link
Copy Markdown

@yselkowitz: once the present PR merges, I will cherry-pick it on top of release-v0.19.1 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-v0.19.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@warrenvw
Copy link
Copy Markdown

After discussion with Yaakov, it's time to merge this PR. There are no known issues which prevent the client from building for all architectures, even if serving, eventing, etc. are only built for x86_64.

@rhuss
Copy link
Copy Markdown

rhuss commented Jan 14, 2021

/lgtm
/approve

Thanks ! Let's get that in for 1.13 ....

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2021
@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhuss, yselkowitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2021
@openshift-merge-robot openshift-merge-robot merged commit d58da33 into openshift:master Jan 14, 2021
@openshift-cherrypick-robot
Copy link
Copy Markdown

@yselkowitz: new pull request created: #581

Details

In response to this:

/cherry-pick release-v0.19.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants