Skip to content
This repository was archived by the owner on Dec 1, 2022. It is now read-only.

[release-v0.25.1] Remove python http server from artifact image#835

Merged
openshift-merge-robot merged 2 commits intoopenshift:release-v0.25.1from
dsimansk:pr/rm-python-http
Nov 8, 2021
Merged

[release-v0.25.1] Remove python http server from artifact image#835
openshift-merge-robot merged 2 commits intoopenshift:release-v0.25.1from
dsimansk:pr/rm-python-http

Conversation

@dsimansk
Copy link
Copy Markdown

@dsimansk dsimansk commented Oct 8, 2021

Let's see how the image build goes.
/hold

/cc @markusthoemmes

@openshift-ci openshift-ci bot requested a review from markusthoemmes October 8, 2021 11:41
@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 8, 2021
markusthoemmes
markusthoemmes reviewed Oct 8, 2021
View reviewed changes
Comment thread openshift/ci-operator/knative-images/client/Dockerfile.cliartifacts
RUN microdnf install -y zip tar gzip
ADD package_cliartifacts.sh LICENSE kn-*-* ./

RUN microdnf install -y zip tar gzip && \
Copy link
Copy Markdown

@markusthoemmes markusthoemmes Oct 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy&paste issue? I don't think this has to be run twice.

Copy link
Copy Markdown
Author

@dsimansk dsimansk Oct 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I wanted to squash it together into one RUN.

@dsimansk
Copy link
Copy Markdown
Author

dsimansk commented Oct 8, 2021

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2021
markusthoemmes
markusthoemmes approved these changes Nov 8, 2021
View reviewed changes
Copy link
Copy Markdown

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2021
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Nov 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, markusthoemmes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [dsimansk,markusthoemmes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9a20bb4 into openshift:release-v0.25.1 Nov 8, 2021
@dsimansk
Copy link
Copy Markdown
Author

dsimansk commented Nov 9, 2021

/cherry-pick main

@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Nov 9, 2021

@dsimansk: new pull request created: #859

Details

In response to this:

/cherry-pick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 9, 2021
Merged
@dsimansk dsimansk deleted the pr/rm-python-http branch November 9, 2021 08:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@markusthoemmes markusthoemmes markusthoemmes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@markusthoemmes markusthoemmes

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dsimansk @openshift-cherrypick-robot @markusthoemmes @openshift-merge-robot