This repository was archived by the owner on Dec 1, 2022. It is now read-only.
[0.26] Embed event plugin#905
Merged
openshift-merge-robot merged 3 commits intoopenshift:release-v0.26.0from Dec 10, 2021
Merged
[0.26] Embed event plugin#905openshift-merge-robot merged 3 commits intoopenshift:release-v0.26.0from
openshift-merge-robot merged 3 commits intoopenshift:release-v0.26.0from
Conversation
Yep, that's OK. There's another PR to bump that to released one.
Just wondering, should we add the variable to spec file? or is it okay right now? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cardil, dsimansk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
cardil
added a commit
to cardil/knative-client
that referenced
this pull request
Feb 23, 2022
openshift-merge-robot
pushed a commit
that referenced
this pull request
Feb 23, 2022
* Allow overriding of build.sh for downstream projects (knative#1544) * Adding override script for kn-plugin-event (#910) * Embed event plugin (#905)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR embeds kn-plugin-event for 0.26 release of kn cli.
This utilizes backported knative#1544
@lance: I needed to bump kn-plugin-func to latest
release-nextas currently used hash is no longer present.@Kaustubh-pande: use
KN_PLUGIN_EVENT_SENDER_IMAGEto override nvr of kn-event-sender image: