Skip to content
This repository was archived by the owner on Dec 1, 2022. It is now read-only.

[release-v0.26.0] Add kn-event-image to spec file#907

Merged
openshift-merge-robot merged 3 commits intoopenshift:release-v0.26.0from
dsimansk:pr/add-event-image-to-spec
Dec 10, 2021
Merged

[release-v0.26.0] Add kn-event-image to spec file#907
openshift-merge-robot merged 3 commits intoopenshift:release-v0.26.0from
dsimansk:pr/add-event-image-to-spec

Conversation

@dsimansk
Copy link
Copy Markdown

@dsimansk dsimansk commented Dec 10, 2021

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2021
cardil
cardil suggested changes Dec 10, 2021
View reviewed changes
Copy link
Copy Markdown

@cardil cardil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits

Comment thread openshift-serverless-clients.spec Outdated
Comment thread openshift-serverless-clients.spec Outdated
dsimansk and others added 2 commits December 10, 2021 13:21
@dsimansk @cardil
Update openshift-serverless-clients.spec
9d68b43 
Co-authored-by: Chris Suszynski <krzysztof.suszynski@gmail.com>
@dsimansk @cardil
Update openshift-serverless-clients.spec
b04e3ae 
Co-authored-by: Chris Suszynski <krzysztof.suszynski@gmail.com>
cardil
cardil approved these changes Dec 10, 2021
View reviewed changes
Copy link
Copy Markdown

@cardil cardil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Kaustubh-pande
Copy link
Copy Markdown

Kaustubh-pande commented Dec 10, 2021

/lgtm

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Dec 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dsimansk, Kaustubh-pande

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2021
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Dec 10, 2021

@dsimansk: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit f2b8747 into openshift:release-v0.26.0 Dec 10, 2021
cardil added a commit to cardil/knative-client that referenced this pull request Dec 23, 2021
@dsimansk @cardil
[release-v0.26.0] Add kn-event-image to spec file (openshift#907)
bdbdb2b 
* [release-v0.26.0] Add kn-event-image to spec file

* Update openshift-serverless-clients.spec

Co-authored-by: Chris Suszynski <krzysztof.suszynski@gmail.com>

* Update openshift-serverless-clients.spec

Co-authored-by: Chris Suszynski <krzysztof.suszynski@gmail.com>

Co-authored-by: Chris Suszynski <krzysztof.suszynski@gmail.com>
@dsimansk
Copy link
Copy Markdown
Author

dsimansk commented Feb 17, 2022

/cherrypick release-v1.0.0
/cherrypick main

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 17, 2022
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Feb 17, 2022

@dsimansk: new pull request created: #970

Details

In response to this:

/cherrypick release-v1.0.0
/cherrypick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Kaustubh-pande Kaustubh-pande Awaiting requested review from Kaustubh-pande

1 more reviewer

@cardil cardil cardil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cardil cardil

@Kaustubh-pande Kaustubh-pande

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dsimansk @Kaustubh-pande @openshift-cherrypick-robot @cardil @openshift-merge-robot