This repository was archived by the owner on Nov 28, 2022. It is now read-only.
[release-v0.23] Backports for conformance tests#1350
Merged
openshift-ci[bot] merged 2 commits intoAug 5, 2021
Conversation
* Use test namespaces from pre-defined range * ReuseNamespace flag * ReuseNamespace variable in lib package * prevents import cycle when flags are accessed directly from the lib package * Fix gofmt * Fix goimports * Remove the last occurrence of import cycle * Remove unused variable * Fix detection of NotFound api error * also make the retry count and interval shorter to speed up things * Delete NS only if we created it * leave previously existing namespaces there * Call CreateNamespaceWithRetry directly
* Create RBAC according to the test namespace
* most tests will use just the serviceAccount that has the same name as
the test namespace
* tests using ApiServerSource will user serviceAccount that is named as
follows: ${namespace}-eventwatcher
* Script for creating necessary RBAC for conformance tests
* Readme for running Conformance tests as project admin
* Fix imports
* Minor update for readme
* Fix goimport
* Do not fail if ServiceAccount already exists
* Fix goftm
* Mark tests requiring cluster-admin with specific build tag
* Move the creation of SA,Role,RoleBinding close to namespace creation
* since the name of the resources is aligned with the name of the
namespace it makes sense to create them only once, at the same time as
the namespace
* Formatting
* Move remaining creation of SA,Role,RoleBinding
openshift-ci
Bot
added
the
area/test-and-release
openshift-ci
Bot
added
the
approved
Author
|
Should I also backport this to v0.23.0 ? (or the sync with v0.23 will be done automatically) |
Author
|
/retest |
1 similar comment
Author
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, mgencur The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backporting commits that make it possible to run coformance tests as a project admin user.