Skip to content
This repository was archived by the owner on Nov 28, 2022. It is now read-only.

[release-v0.24] Backport of run conformance tests as project admin#1351

Merged
openshift-ci[bot] merged 1 commit into
openshift:release-v0.24from
mgencur:conformance-v0.24
Aug 4, 2021
Merged

[release-v0.24] Backport of run conformance tests as project admin#1351
openshift-ci[bot] merged 1 commit into
openshift:release-v0.24from
mgencur:conformance-v0.24

Conversation

@mgencur
Copy link
Copy Markdown

@mgencur mgencur commented Aug 3, 2021

Backporting the exact same commit from upstream.

* Create RBAC according to the test namespace

* most tests will use just the serviceAccount that has the same name as
the test namespace
* tests using ApiServerSource will user serviceAccount that is named as
follows: ${namespace}-eventwatcher

* Script for creating necessary RBAC for conformance tests

* Readme for running Conformance tests as project admin

* Fix imports

* Minor update for readme

* Fix goimport

* Do not fail if ServiceAccount already exists

* Fix goftm

* Mark tests requiring cluster-admin with specific build tag

* Move the creation of SA,Role,RoleBinding close to namespace creation

* since the name of the resources is aligned with the name of the
namespace it makes sense to create them only once, at the same time as
the namespace

* Formatting

* Move remaining creation of SA,Role,RoleBinding
@openshift-ci openshift-ci Bot requested review from alanfx and markusthoemmes August 3, 2021 07:08
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2021
Copy link
Copy Markdown
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2021
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Aug 4, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot merged commit 7e13640 into openshift:release-v0.24 Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Issues or PRs related to test and release lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants