Different cron times for branches for periodics by aliok · Pull Request #1639 · openshift/knative-eventing

aliok · 2022-02-16T11:38:13Z

Different cron times for branches for periodics

aliok · 2022-02-16T11:39:01Z

 }

-image_deps=$(generate_image_dependencies)
+image_deps="$(generate_image_dependencies)"


Also touched this based on @devguyio comment here: #1636 (review)

pierDipi · 2022-02-16T11:44:51Z

+function generate_cron_expression {
+  if [[ "$branch" == "knative-v0.25.3" ]]; then
+    echo '0 1 * * 1-5'
+  elif [[ "$branch" == "knative-v0.26" ]]; then
+    echo '0 3 * * 1-5'
+  elif [[ "$branch" == "knative-v1.0" ]]; then
+    echo '0 5 * * 1-5'
+  elif [[ "$branch" == "knative-v1.1" ]]; then
+    echo '0 7 * * 1-5'
+  elif [[ "$branch" == "knative-v1.2" ]]; then
+    echo '0 9 * * 1-5'
+  fi
+}
+


One idea to avoid hard-coding is to use the last number of minor version for the hour:

knative-v0.25.3 -> 0 5 * * 1-5
knative-v0.26 -> 0 6 * * 1-5
knative-v1.0 -> 0 0 * * 1-5
knative-v1.1 -> 0 1 * * 1-5
knative-v1.2 -> 0 2 ** 1-5

If we don't do this, can we update docs?
https://github.com/openshift/knative-eventing#release-schedule

Update with what? Sorry I didn't understand

If we cut another branch, knative-v1.3 this doesn't produce any cron expression, so when we cut a new branch or remove an old one we need to update this logic here

Or we're missing an else branch.

By default it will fallback to the old cron expression. We would need to touch the file though, you are right.

knative-v0.25.3 -> 0 5 * * 1-5 knative-v0.26 -> 0 6 * * 1-5 knative-v1.0 -> 0 0 * * 1-5 knative-v1.1 -> 0 1 * * 1-5 knative-v1.2 -> 0 2 ** 1-5

This is good, but just adds Bash complexity IMO, which I am not a very big fan of.

Added some docs in README now

cc @pierDipi

devguyio

/lgtm
/hold

keeping it for @pierDipi to unhold , I'm fine with doing the hard coding now until we validate the idea as I mentioned in the other PR

pierDipi

/lgtm
/approve

pierDipi · 2022-02-17T07:20:03Z

/unhold

openshift-ci · 2022-02-17T07:20:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, devguyio, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [aliok,devguyio,pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pierDipi · 2022-02-22T08:31:10Z

/cherry-pick release-1.2

pierDipi · 2022-02-22T08:31:17Z

/cherry-pick release-v1.2

pierDipi · 2022-02-22T08:31:23Z

/cherry-pick release-v1.1

pierDipi · 2022-02-22T08:31:27Z

/cherry-pick release-v1.0

pierDipi · 2022-02-22T08:31:35Z

/cherry-pick release-v0.26

openshift-cherrypick-robot · 2022-02-22T08:31:50Z

@pierDipi: cannot checkout release-1.2: error checking out release-1.2: exit status 1. output: error: pathspec 'release-1.2' did not match any file(s) known to git

Details

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2022-02-22T08:31:53Z

@pierDipi: #1639 failed to apply on top of branch "release-v1.2":

Applying: Different cron times for branches
Applying: Wrap function invocations in quotes
Applying: Add instructions
Using index info to reconstruct a base tree...
M	README.md
Falling back to patching base and 3-way merge...
Auto-merging README.md
CONFLICT (content): Merge conflict in README.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 Add instructions
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick release-v1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2022-02-22T08:31:59Z

@pierDipi: #1639 failed to apply on top of branch "release-v1.1":

Applying: Different cron times for branches
Applying: Wrap function invocations in quotes
Applying: Add instructions
Using index info to reconstruct a base tree...
M	README.md
Falling back to patching base and 3-way merge...
Auto-merging README.md
CONFLICT (content): Merge conflict in README.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 Add instructions
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick release-v1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2022-02-22T08:32:02Z

@pierDipi: #1639 failed to apply on top of branch "release-v1.0":

Applying: Different cron times for branches
Applying: Wrap function invocations in quotes
Applying: Add instructions
Using index info to reconstruct a base tree...
M	README.md
Falling back to patching base and 3-way merge...
Auto-merging README.md
CONFLICT (content): Merge conflict in README.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 Add instructions
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick release-v1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2022-02-22T08:32:10Z

@pierDipi: #1639 failed to apply on top of branch "release-v0.26":

Applying: Different cron times for branches
Applying: Wrap function invocations in quotes
Applying: Add instructions
Using index info to reconstruct a base tree...
M	README.md
Falling back to patching base and 3-way merge...
Auto-merging README.md
CONFLICT (content): Merge conflict in README.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 Add instructions
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick release-v0.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

* Different cron times for branches * Wrap function invocations in quotes * Add instructions Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Ali Ok <aliok@redhat.com>

* Different cron times for branches * Wrap function invocations in quotes * Add instructions Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Different cron times for branches * Wrap function invocations in quotes * Add instructions Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Ali Ok <aliok@redhat.com>

aliok added 2 commits February 16, 2022 14:24

Different cron times for branches

0793ede

Wrap function invocations in quotes

09e1a28

aliok mentioned this pull request Feb 16, 2022

[release-v1.2] Different cron times for branches for periodics #1636

Closed

5 tasks

openshift-ci Bot requested review from devguyio and matzew February 16, 2022 11:38

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2022

aliok commented Feb 16, 2022

View reviewed changes

pierDipi reviewed Feb 16, 2022

View reviewed changes

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 16, 2022

devguyio approved these changes Feb 16, 2022

View reviewed changes

openshift-ci Bot assigned devguyio Feb 16, 2022

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2022

Add instructions

906974f

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2022

pierDipi approved these changes Feb 17, 2022

View reviewed changes

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2022

openshift-ci Bot assigned pierDipi Feb 17, 2022

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2022

openshift-merge-robot merged commit 442d1e3 into openshift:main Feb 17, 2022

pierDipi mentioned this pull request Feb 22, 2022

[v1.2] Different cron times for branches for periodics (#1639) #1640

Merged

aliok deleted the 2022-02-16-update-ci-time-main branch November 30, 2023 09:26

Conversation

aliok commented Feb 16, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

devguyio left a comment

Choose a reason for hiding this comment

Uh oh!

pierDipi left a comment

Choose a reason for hiding this comment

Uh oh!

pierDipi commented Feb 17, 2022

Uh oh!

openshift-ci Bot commented Feb 17, 2022

Uh oh!

pierDipi commented Feb 22, 2022

Uh oh!

pierDipi commented Feb 22, 2022

Uh oh!

pierDipi commented Feb 22, 2022

Uh oh!

pierDipi commented Feb 22, 2022

Uh oh!

pierDipi commented Feb 22, 2022

Uh oh!

openshift-cherrypick-robot commented Feb 22, 2022

Uh oh!

openshift-cherrypick-robot commented Feb 22, 2022

Uh oh!

openshift-cherrypick-robot commented Feb 22, 2022

Uh oh!

openshift-cherrypick-robot commented Feb 22, 2022

Uh oh!

openshift-cherrypick-robot commented Feb 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants