This repository was archived by the owner on Nov 28, 2022. It is now read-only.
[release-v1.7] Correct the upstream 1.7 release adjustments on midstream branch#1872
Merged
openshift-merge-robot merged 2 commits intoSep 7, 2022
Merged
Conversation
bumping knative.dev/hack e9a8475...d35c718: > d35c718 [release-1.7] go run... (# 211) bumping knative.dev/hack/schema e9a8475...d35c718: > d35c718 [release-1.7] go run... (# 211) Signed-off-by: Knative Automation <automation@knative.team> Signed-off-by: Knative Automation <automation@knative.team>
bumping knative.dev/hack d35c718...8d1e4cc: > 8d1e4cc fix go run invocation of github hub cli (# 213) bumping knative.dev/hack/schema d35c718...8d1e4cc: > 8d1e4cc fix go run invocation of github hub cli (# 213) Signed-off-by: Knative Automation <automation@knative.team> Signed-off-by: Knative Automation <automation@knative.team>
openshift-ci
Bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For release 1.7.0 in upstream, some things were simply missing.
Those were added in two PRs to the upstream branch:
This PR lands those changes (resulting in upstream 1.7.1) to our midstream 1.7 branch...