This repository was archived by the owner on Nov 28, 2022. It is now read-only.
[release-v0.17.2] Backport of upstream PR 4460#949
Merged
openshift-merge-robot merged 3 commits intoNov 5, 2020
Merged
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci-robot
added
the
area/test-and-release
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Author
openshift-ci-robot
added
the
do-not-merge/hold
cardil
added a commit
to cardil/openshift-release
that referenced
this pull request
Nov 5, 2020
This change targets the problem of how to get report from cluster. Clusters may have different networking setup, and it might not be possible to directly make HTTP request from outside of cluster. Previous approach used to guess an external address of cluster. That for sure fails on OpenShift deployed on AWS. This approach deploys a special Job that, being inside cluster, can download a report and print it in it's logs. Then test client can fetch logs of completed job, and parse it, replay the logs, and process report further. Removal of unneeded external node address package
cardil
force-pushed
the
bugfix/backport-pr-4460
branch
from
82543b2 to
ee731f4
Compare
Author
|
/unhold This PR should be now ready to review and merge. There are 3 commits:
There is also connected openshift/release#13412 in flight |
openshift-ci-robot
removed
the
do-not-merge/hold
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cardil, devguyio, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
openshift-merge-robot
added a commit
to openshift/release
that referenced
this pull request
Nov 5, 2020
…-for-pr-949 Adding changes generated from openshift/knative-eventing#949
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is meant to be applied after #948 (a revert).
This is a backport of an upstream PR knative#4460, which addresses Upgrade tests wathola-receiver delivery report fetching (knative#3175) in a proper way.
Those changes are required to run Eventing upgrade tests on OpenShift (GA requirement).