Download nightly build manifest when version is CI

[nak3]

#1191 changed to download the manifest from https://github.com/knative/$component/releases/download/knative-$release_suffix/$file but the nightly build does not exist in the URL.

This patch fixes it.

[nak3]

current error:

00:35:12  ++ basename ./test/test_images/multicontainer/sidecarcontainer
00:35:12  + local image_base=sidecarcontainer
00:35:12  + mkdir -p openshift/ci-operator/knative-test-images/sidecarcontainer
00:35:12  + bin=sidecarcontainer
00:35:12  + envsubst
00:35:12  ./openshift/release/generate-release.sh ci
00:35:12  Writing resolved yaml to openshift/release/knative-serving-ci.yaml
00:35:12  --2022-08-02 20:35:12--  https://github.com/knative/serving/releases/download/knative-c0/serving-crds.yaml
00:35:12  Resolving github.com (github.com)... 140.82.113.3
00:35:12  Connecting to github.com (github.com)|140.82.113.3|:443... connected.
00:35:12  HTTP request sent, awaiting response... 404 Not Found
00:35:12  2022-08-02 20:35:12 ERROR 404: Not Found.

[skonto]

@nak3
Ok missed that we call generate-release with ci when we cut the branch, good catch. However we dont need to download the nightly files just skip them because they are not going to be used by the S-O or anywhere. S-O will not fetch them at all and actually we are going to override the files under artifacts dir since we have multiple calls here https://github.com/openshift/knative-serving/blob/main/openshift/release/create-release-branch.sh#L18-L19 that will call download_release_artifacts multiple times.
The artifacts dir should only contain the release files the S-O is going to get when running openshift-knative-operator/hack/update-manifests.sh.
So if release == "ci' let's skip calling download_release_artifacts here.

Maybe the right place to add download_release_artifacts call is not in the generate-release file but in create-release-branch.sh directly and call it once there. As a side note it is also confusing that we call make generate-release four times in create-release-branch.sh.

[nak3]

Thank you @skonto I will close this PR so would you mind opening the PR as you wanted to change?
I can add the line in https://github.com/openshift/knative-serving/blob/main/openshift/release/generate-release.sh#L12 to skip calling it but maybe you want to change more?

[skonto]

I can add the line in https://github.com/openshift/knative-serving/blob/main/openshift/release/generate-release.sh#L12 to skip calling it

Yes please do. Let's add that line and we can clean up when we unify manifest generation as a next step we have some internal technical debt there.

[skonto]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [nak3,skonto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment