Skip to content
This repository was archived by the owner on Dec 1, 2022. It is now read-only.

[release-v1.4] Tests for encryption with Kourier local gateway (#13263)#1233

Merged
openshift-merge-robot merged 1 commit into
openshift:release-v1.4from
mgencur:tls_v1.4
Sep 6, 2022
Merged

[release-v1.4] Tests for encryption with Kourier local gateway (#13263)#1233
openshift-merge-robot merged 1 commit into
openshift:release-v1.4from
mgencur:tls_v1.4

Conversation

@mgencur
Copy link
Copy Markdown

@mgencur mgencur commented Sep 6, 2022

Backport of knative@6d3d676
The test for encryption for cluster-local services won't be active in this repo. It will be consumed by other repositories such as serverless-operator where it will be activated.

  • Generate Secrets
  • Commit generated cert-secret.yaml
  • httpproxy enables tls client
  • httpproxy uses https when CA_CERT specified
  • Pass CA_CERT and SERVER_NAME env variables properly to tests

* Generate Secrets

* Commit generated cert-secret.yaml

* httpproxy enables tls client

* httpproxy uses https when CA_CERT specified

* Pass CA_CERT and SERVER_NAME env variables properly to tests
@openshift-ci openshift-ci Bot requested review from nak3 and skonto September 6, 2022 07:12
@openshift-ci openshift-ci Bot added area/test-and-release Issues or PRs related to test and release approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 6, 2022
@skonto
Copy link
Copy Markdown

skonto commented Sep 6, 2022

/lgtm
/hold for tests to pass

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2022
@skonto
Copy link
Copy Markdown

skonto commented Sep 6, 2022

I think we need this in 1.5+ too, assuming tls support is there.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2022
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Sep 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mgencur, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mgencur
Copy link
Copy Markdown
Author

mgencur commented Sep 6, 2022

@skonto Yes. I will backport it to 1.5, 1.6, 1.7 too.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Sep 6, 2022

@mgencur: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mgencur
Copy link
Copy Markdown
Author

mgencur commented Sep 6, 2022

Tests passed.

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2022
@openshift-merge-robot openshift-merge-robot merged commit 99de2ba into openshift:release-v1.4 Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Issues or PRs related to test and release lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants