Skip to content
This repository was archived by the owner on Dec 1, 2022. It is now read-only.

[release-v1.7] Tests for encryption with Kourier local gateway#1234

Merged
nak3 merged 7 commits intoopenshift:release-v1.7from
mgencur:tls_v1.7
Sep 13, 2022
Merged

[release-v1.7] Tests for encryption with Kourier local gateway#1234
nak3 merged 7 commits intoopenshift:release-v1.7from
mgencur:tls_v1.7

Conversation

@mgencur
Copy link
Copy Markdown

@mgencur mgencur commented Sep 6, 2022

Backport of knative@6d3d676

  • Pull changes from upstream
  • Modify scripts in openshift/ to enable internal tls and tls for cluster-local gateway
  • Pull the new make target for running tls tests from "main" branch.

@openshift-ci openshift-ci Bot requested review from mvinkler and nak3 September 6, 2022 07:47
@openshift-ci openshift-ci Bot added area/test-and-release Issues or PRs related to test and release approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 6, 2022
@mgencur
Copy link
Copy Markdown
Author

mgencur commented Sep 6, 2022

/hold
Branch release-v1.7 doesn't have CI yet.
I will send the same changes against release-v1.6 and test it there first.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2022
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2022
@mgencur
Tests for encryption with Kourier local gateway (knative#13263)
2a7dfc8 
* Generate Secrets

* Commit generated cert-secret.yaml

* httpproxy enables tls client

* httpproxy uses https when CA_CERT specified

* Pass CA_CERT and SERVER_NAME env variables properly to tests

* Avoid using cluster-local certificates for external services
@mgencur
Enable tls tests for cluster-local Kourier gateway
be5c04b 
* Need to create test resources including the test namespace first
before installing Knative so that applying
test/config/tls/cert-secret.yaml succeeds
@mgencur
Use knative-serving-ingress ns for deploying server-certs
d2194b7
@mgencur
Deploy certificates at test phase
b80ac43
@mgencur
Separate test and install of installing certs
d519349
@mgencur
Wait for knative-serving-ingress to exist
40bbce3
@mgencur
Use yq write to replace namespace
29a1052
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 12, 2022
@nak3
Copy link
Copy Markdown

nak3 commented Sep 12, 2022

/retest
/lgtm

  *[2022-09-12T06:47:48Z]NoClusters: No clusters in pool are ready to be claimed

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2022
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Sep 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mgencur, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nak3 nak3 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 13, 2022
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 13, 2022

/retest-required

Remaining retests: 0 against base HEAD 56d520d and 2 for PR HEAD 29a1052 in total

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Sep 13, 2022

@mgencur: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/48-e2e-aws-ocp-48 29a1052 link true /test 48-e2e-aws-ocp-48

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nak3 nak3 merged commit c116e14 into openshift:release-v1.7 Sep 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mvinkler mvinkler Awaiting requested review from mvinkler

@nak3 nak3 Awaiting requested review from nak3

Assignees

@nak3 nak3

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Issues or PRs related to test and release lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mgencur @nak3 @openshift-ci-robot @openshift-merge-robot