Skip to content
This repository was archived by the owner on Dec 1, 2022. It is now read-only.

[release-v1.6] Tests for encryption with Kourier local gateway#1235

Merged
openshift-merge-robot merged 11 commits into
openshift:release-v1.6from
mgencur:tls_v1.6
Sep 9, 2022
Merged

[release-v1.6] Tests for encryption with Kourier local gateway#1235
openshift-merge-robot merged 11 commits into
openshift:release-v1.6from
mgencur:tls_v1.6

Conversation

@mgencur
Copy link
Copy Markdown

@mgencur mgencur commented Sep 6, 2022

Backport of knative@6d3d676

  • Pull changes from upstream
  • Modify scripts in openshift/ to enable internal tls and tls for cluster-local gateway
  • Pull the new make target for running tls tests from "main" branch.

nak3 and others added 7 commits September 6, 2022 10:25
* Enable internal-tls on OCP 4.8

* Use tls to match JOB name
* Add a target to enable internal-tls in Makefile

* Update CI template for internal-tls enabled
* Generate Secrets

* Commit generated cert-secret.yaml

* httpproxy enables tls client

* httpproxy uses https when CA_CERT specified

* Pass CA_CERT and SERVER_NAME env variables properly to tests

* Avoid using cluster-local certificates for external services
* Need to create test resources including the test namespace first
before installing Knative so that applying
test/config/tls/cert-secret.yaml succeeds
@openshift-ci openshift-ci Bot added area/test-and-release Issues or PRs related to test and release approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 6, 2022
@mgencur
Copy link
Copy Markdown
Author

mgencur commented Sep 7, 2022

It works here as well (same as release-v1.5 variant). Reverting the temporary commit for enabling tls by default.

@nak3
Copy link
Copy Markdown

nak3 commented Sep 9, 2022

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2022
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Sep 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mgencur, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 12d9276 and 2 for PR HEAD 1153a32 in total

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Sep 9, 2022

@mgencur: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 5879247 into openshift:release-v1.6 Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Issues or PRs related to test and release lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants