Skip to content
This repository was archived by the owner on Dec 1, 2022. It is now read-only.

[RELEASE-1.5] Fix tls patch#1273

Merged
openshift-merge-robot merged 1 commit into
openshift:release-v1.5from
skonto:fix_tls_hash_1.5
Oct 12, 2022
Merged

[RELEASE-1.5] Fix tls patch#1273
openshift-merge-robot merged 1 commit into
openshift:release-v1.5from
skonto:fix_tls_hash_1.5

Conversation

@skonto
Copy link
Copy Markdown

@skonto skonto commented Oct 10, 2022

@skonto skonto requested a review from nak3 October 10, 2022 14:29
@openshift-ci openshift-ci Bot requested review from mgencur and rhuss October 10, 2022 14:30
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2022
@skonto skonto removed request for mgencur and rhuss October 10, 2022 14:41
@skonto
Copy link
Copy Markdown
Author

skonto commented Oct 10, 2022

/retest

@nak3
Copy link
Copy Markdown

nak3 commented Oct 11, 2022

Since openshift-knative/serverless-operator#1710 is not available in main branch in SO, the 4.6&4.7 is failing.

@skonto
Copy link
Copy Markdown
Author

skonto commented Oct 11, 2022

@nak3

{"severity":"ERROR","timestamp":"2022-10-10T19:59:01.480258634Z","logger":"knative-operator","caller":"controller/controller.go:566","message":"Reconcile error","knative.dev/pod":"knative-operator-webhook-8545f77f8d-w242l","knative.dev/controller":"knative.dev.operator.pkg.reconciler.knativeserving.Reconciler","knative.dev/kind":"operator.knative.dev.KnativeServing","knative.dev/traceid":"0e09d82a-7109-4deb-85b2-d5a2dcd60bc6","knative.dev/key":"knative-serving/knative-serving","duration":"6.178601752s","error":"failed to apply non rbac manifest: no matches for kind "PodDisruptionBudget" in version "policy/v1"","stacktrace":"knative.dev/pkg/controller.(*Impl).handleErr\n\t/go/src/github.com/openshift-knative/serverless-operator/vendor/knative.dev/pkg/controller/controller.go:566\nknative.dev/pkg/controller.(*Impl).processNextWorkItem\n\t/go/src/github.com/openshift-knative/serverless-operator/vendor/knative.dev/pkg/controller/controller.go:543\nknative.dev/pkg/controller.(*Impl).RunContext.func3\n\t/go/src/github.com/openshift-knative/serverless-operator/vendor/knative.dev/pkg/controller/controller.go:491"}

We need to remove the 4.6, 4.7 jobs (not supported in 1.26 ) and add 4.11.
From here: Migrate manifests and API clients to use the policy/v1 API version, available since v1.21. 1.21 is 4.8.

@skonto
Copy link
Copy Markdown
Author

skonto commented Oct 11, 2022

/retest

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Oct 11, 2022

@skonto: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/46-e2e-aws-ocp-46 c601c3f link true /test 46-e2e-aws-ocp-46
ci/prow/47-e2e-aws-ocp-47 c601c3f link true /test 47-e2e-aws-ocp-47

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nak3
Copy link
Copy Markdown

nak3 commented Oct 12, 2022

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2022
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Oct 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 1736fd2 into openshift:release-v1.5 Oct 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants